1.39.0-wmf.39 train is blocked (Flow/Sidebar issue)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

1.39.0-wmf.39 train is blocked (Flow/Sidebar issue)

Antoine Musso-2
Hello,

The 1.39.0-wmf.39 is blocked, immediately after deploying it to group0
wikis, Flow topics ended up being error pages.


When browsing a topic page, there are two issues bubbling up in logstash:

From VectorTemplate->buildSidebar()
* /srv/mediawiki/php-1.35.0-wmf.39/includes/language/Message.php:261
$key must be a string or an array

From Skin->buildSidebar / ElectronPdfServiceHooks::onSidebarBeforeOutput

*
/srv/mediawiki/php-1.35.0-wmf.39/extensions/ElectronPdfService/src/ElectronPdfServiceHooks.php:62
 PHP Notice: Undefined index: print

Which as I understand it causes an exception.

The breaking bug is: https://phabricator.wikimedia.org/T256761

--
Antoine "hashar" Musso
Release Engineering


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: 1.39.0-wmf.39 train is blocked (Flow/Sidebar issue)

Antoine Musso-2

Le 30/06/2020 à 16:51, Antoine Musso a écrit :
> Hello,
>
> The 1.39.0-wmf.39 is blocked, immediately after deploying it to group0
> wikis, Flow topics ended up being error pages.
> ...
> /srv/mediawiki/php-1.35.0-wmf.39/extensions/ElectronPdfService/src/ElectronPdfServiceHooks.php:62
>  PHP Notice: Undefined index: print
> ...
> The breaking bug is: https://phabricator.wikimedia.org/T256761

Hello,

The root cause has been promptly fixed and 1.39.0-wmf.39 is on group 0 now.

In no particular order, thank you: Taavi "Majavah" Väänänen, Demian, Jon
Robson and Gergő "tgr" Tisza.

--
Antoine "hashar" Musso

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l