Bug 62233 - PHP Warnings [localhost] after updating to HEAD version: Cannot modify header information - headers already sent in /includes/WebResponse.php on line 38

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug 62233 - PHP Warnings [localhost] after updating to HEAD version: Cannot modify header information - headers already sent in /includes/WebResponse.php on line 38

Thomas Gries
RE: https://bugzilla.wikimedia.org/show_bug.cgi?id=62233


There's a problem is somewhere in the core which causes warnings.
Can anyone confirm who runs a recent core version younger than 2014-02-28 ?


Logfiles in my recently upgraded (git pull) installations are filling up
with warnings

        "Cannot modify header information - headers already sent in /includes/WebResponse.php on line 38"
        (No. My PHP files do not have spooky blank lines.)


With "bisect"
I determined that the problem appears to be introduced by a certain commit and
seems to be caused by the ***MERGE*** of9e66a63af83427a01d66795ac64b793ff4473218  <https://gerrit.wikimedia.org/r/#q,9e66a63af83427a01d66795ac64b793ff4473218,n,z>


commit830eb262fe76ef3ad49f91daad5e152af8ce9bc4  <https://gerrit.wikimedia.org/r/#q,830eb262fe76ef3ad49f91daad5e152af8ce9bc4,n,z>  ==> NOT OKAY (triggers warning)
Merge: 25466a0 9e66a63
Author: jenkins-bot
Date:   Fri Feb 28 02:19:02 2014 +0000

     Merge "Use inContentLanguage for dropdown messages in HTMLFormField"



commit9e66a63af83427a01d66795ac64b793ff4473218  <https://gerrit.wikimedia.org/r/#q,9e66a63af83427a01d66795ac64b793ff4473218,n,z>  ==> OKAY (does not trigger warnings)
Author: Marius
Date:   Fri Feb 28 03:12:10 2014 +0100

     Use inContentLanguage for dropdown messages in HTMLFormField
     to restore b/c for now.

     Bug: 61942
     Change-Id:I2741ef940d83eeb564e89e20378fb4004cfe5b83  <https://gerrit.wikimedia.org/r/#q,I2741ef940d83eeb564e89e20378fb4004cfe5b83,n,z>
     

Therefore I think, that the problem is caused by something messed up in this diff:

http://git.wikimedia.org/compare/mediawiki%2Fcore.git/830eb262fe76ef3ad49f91daad5e152af8ce9bc4..9e66a63af83427a01d66795ac64b793ff4473218


I kindly ask anyone who can to help to look into that problem.




_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug 62233 - PHP Warnings [localhost] after updating to HEAD version: Cannot modify header information - headers already sent in /includes/WebResponse.php on line 38

Brad Jorsch (Anomie)
The cause is https://gerrit.wikimedia.org/r/#/c/113038/


On Tue, Mar 11, 2014 at 3:29 PM, Thomas Gries <[hidden email]> wrote:

> RE: https://bugzilla.wikimedia.org/show_bug.cgi?id=62233
>
>
> There's a problem is somewhere in the core which causes warnings.
> Can anyone confirm who runs a recent core version younger than 2014-02-28 ?
>
>
> Logfiles in my recently upgraded (git pull) installations are filling up
> with warnings
>
>         "Cannot modify header information - headers already sent in
> /includes/WebResponse.php on line 38"
>         (No. My PHP files do not have spooky blank lines.)
>
>
> With "bisect"
> I determined that the problem appears to be introduced by a certain commit
> and
> seems to be caused by the ***MERGE*** of9e66a63af83427a01d66795ac64b793ff4473218
>  <https://gerrit.wikimedia.org/r/#q,9e66a63af83427a01d66795ac64b79
> 3ff4473218,n,z>
>
>
> commit830eb262fe76ef3ad49f91daad5e152af8ce9bc4  <
> https://gerrit.wikimedia.org/r/#q,830eb262fe76ef3ad49f91daad5e15
> 2af8ce9bc4,n,z>  ==> NOT OKAY (triggers warning)
> Merge: 25466a0 9e66a63
> Author: jenkins-bot
> Date:   Fri Feb 28 02:19:02 2014 +0000
>
>     Merge "Use inContentLanguage for dropdown messages in HTMLFormField"
>
>
>
> commit9e66a63af83427a01d66795ac64b793ff4473218  <
> https://gerrit.wikimedia.org/r/#q,9e66a63af83427a01d66795ac64b79
> 3ff4473218,n,z>  ==> OKAY (does not trigger warnings)
> Author: Marius
> Date:   Fri Feb 28 03:12:10 2014 +0100
>
>     Use inContentLanguage for dropdown messages in HTMLFormField
>     to restore b/c for now.
>
>     Bug: 61942
>     Change-Id:I2741ef940d83eeb564e89e20378fb4004cfe5b83  <
> https://gerrit.wikimedia.org/r/#q,I2741ef940d83eeb564e89e20378fb
> 4004cfe5b83,n,z>
>
> Therefore I think, that the problem is caused by something messed up in
> this diff:
>
> http://git.wikimedia.org/compare/mediawiki%2Fcore.git/
> 830eb262fe76ef3ad49f91daad5e152af8ce9bc4..9e66a63af83427a01d66795ac64b79
> 3ff4473218
>
>
> I kindly ask anyone who can to help to look into that problem.
>
>
>
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l




--
Brad Jorsch (Anomie)
Software Engineer
Wikimedia Foundation
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l