Bug in user prefereces

classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Siebrand Mazeland
I thought it didn't have anything to do with the preferences system itself,
but was a performance issue; the context switching needed to get the
preferences everytime would be too darn expensive. I vaguely recall Domas
mentioning something like that...

Siebrand

-----Oorspronkelijk bericht-----
Van: [hidden email]
[mailto:[hidden email]] Namens Alex
Verzonden: donderdag 6 november 2008 20:49
Aan: Wikimedia developers
Onderwerp: Re: [Wikitech-l] Bug in user prefereces

I don't think there's anyone who thinks that global preferences would be a
bad idea (or if there are, they're a tiny minority). It just hasn't been
done yet. Any global preferences system would probably come after a rewrite
of the current preferences system[1] as it would probably be done in mostly
the same way. Doing it one preference at a time would be rather inefficient.

The main issue is that you may not want the same preferences everywhere.
For example, email notification settings, which also has the issue of not
being consistent across projects. I may want notification for watchlisted
changes on small projects I don't check often, but not for commons and meta,
as I check those often. Or you may not want to use UTC on projects that use
a different default timezone for signatures and such. So the global
preferences would have to be locally overridable.

[1]<http://www.mediawiki.org/wiki/Deficits_of_the_current_preferences_system
>
--
Alex (wikipedia:en:User:Mr.Z-man)


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Aryeh Gregor
On Thu, Nov 6, 2008 at 2:57 PM, Siebrand Mazeland <[hidden email]> wrote:
> I thought it didn't have anything to do with the preferences system itself,
> but was a performance issue; the context switching needed to get the
> preferences everytime would be too darn expensive. I vaguely recall Domas
> mentioning something like that...

Domas doesn't want a hit on the global user table for every page view,
IIRC, no.  However, there could be implementations that avoid that,
perhaps using memcached, or just stupid denormalization to all the
other databases (a button saying "change this preference on all my
accounts and any new ones").

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Bugzilla from andrew@epstone.net
On Fri, Nov 7, 2008 at 11:18 AM, Aryeh Gregor
<[hidden email]> wrote:
> Domas doesn't want a hit on the global user table for every page view,
> IIRC, no.  However, there could be implementations that avoid that,
> perhaps using memcached, or just stupid denormalization to all the
> other databases (a button saying "change this preference on all my
> accounts and any new ones").

We already cache global user objects in memcached, and memcached hits
are cheap, anyway (on the order of a few hundred us).

--
Andrew Garrett

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Arne 'Timwi' Heizmann
In reply to this post by Mormegil
Petr Kadlec wrote:
> And what do you think we should do?

MediaWiki should not try to change the password if no new password was
entered.

> From our viewpoint, the situation is identical to the user trying to
> set his password to empty string.

So put a short piece of text next to be text box saying "empty password
not allowed" (if that is the only restriction).

Timwi


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Mormegil
2008/11/8 Timwi <[hidden email]>:
> Petr Kadlec wrote:
>> And what do you think we should do?
>
> MediaWiki should not try to change the password if no new password was
> entered.

Some wikis allow users to have no password (and it's still the default
setting), and in that case, it is a completely valid operation (see
http://www.mediawiki.org/wiki/Manual:$wgMinimalPasswordLength).

-- [[cs:User:Mormegil | Petr Kadlec]]

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Aryeh Gregor
On Sat, Nov 8, 2008 at 1:40 PM, Petr Kadlec <[hidden email]> wrote:
> Some wikis allow users to have no password (and it's still the default
> setting), and in that case, it is a completely valid operation (see
> http://www.mediawiki.org/wiki/Manual:$wgMinimalPasswordLength).

That's even scarier.  In this situation, the password would get
silently set to empty.

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Bug in user prefereces

Brion Vibber-3
In reply to this post by Mormegil
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Petr Kadlec wrote:

> Hi!
>
> 2008/11/5 Timwi <[hidden email]>:
>> I get the following message:
>>
>>        Your password is invalid or too short. It must have at least 1
>>        character and be different from your username.
>>
>> If the password boxes are empty, the system should not assume that I was
>> trying to change my password.
>
> If the password boxes are really empty, the system assumes that.
> However, if you use some password-remembering browser (such as
> Firefox), it "helpfully" pre-fills the "current password" box, leading
> to this. At least, that is what happened to me. Be sure to manually
> clear the "old password" editbox before changing other preferences,
> and everything should work fine.

We're still kind of assuming it's something like this problem. :)

The proper thing to do is to move the password reset form out of
preferences to its own form -- it really shouldn't be there anyway.

- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkh2FcACgkQwRnhpk1wk45Q7ACdEWr/P4qEcEEEwnGG98QZdLkY
GlEAn3hgmQScWotUBj5CuRwfKE7JwzWF
=0B9r
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
12