CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical)

Daniel Kinzler-3

I propose for Aryeh Gregor to be granted the right to approve changes against
MediaWiki core and extensions, by adding him to the mediawiki LDAP group.

Please voice support or concerns on
<https://phabricator.wikimedia.org/T230979>

Aryeh has been contributing to MediaWiki on and off for a decade or so, both as
a volunteer and a contractor. He joined gerrit only a year ago, but he had
commit access already back in the day when MediaWiki was still managed on SVN.
In the time I have been working with Aryeh, he has shown excellent skill and
good judgement. Granting him merge rights would allow him to contribute not only
by writing code, but also by approving changes made by others.

Aryeh commented on the ticket to note the following:

> My older contributions are available via git log --author simetrical. I
> couldn't find a webpage that would display the results of the search that I
> could link to. Note that that includes things from the SVN era that I only
> committed and didn't author, so it's inflated (probably only slightly). But if
> we leave that aside, according to git shortlog -sne, I have 1052 commits (after
> updating .mailmap to merge the three different e-mail addresses I've used).
> Surprisingly, this still makes me the #19 all-time contributor by number of
> commits. I think I always tended to break up my commits more than a lot of
> people, though.


--
Daniel Kinzler
Principal Software Engineer, Core Platform
Wikimedia Foundation

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical)

Marko Obrovac
Hello,

Just a quick note that, as per the new Gerrit policy~[1], the request task
will stay open for one week. If consensus is reached in that time frame, it
will be enacted by one of the gerrit administrators, so please voice your
support and/or concerns at your earliest convenience.

Cheers,
Marko Obrovac, PhD
Senior Software Engineer
Wikimedia Foundation

[1] https://www.mediawiki.org/wiki/Gerrit/Privilege_policy


On Thu, 22 Aug 2019 at 12:23, Daniel Kinzler <[hidden email]> wrote:

>
> I propose for Aryeh Gregor to be granted the right to approve changes
> against
> MediaWiki core and extensions, by adding him to the mediawiki LDAP group.
>
> Please voice support or concerns on
> <https://phabricator.wikimedia.org/T230979>
>
> Aryeh has been contributing to MediaWiki on and off for a decade or so,
> both as
> a volunteer and a contractor. He joined gerrit only a year ago, but he had
> commit access already back in the day when MediaWiki was still managed on
> SVN.
> In the time I have been working with Aryeh, he has shown excellent skill
> and
> good judgement. Granting him merge rights would allow him to contribute
> not only
> by writing code, but also by approving changes made by others.
>
> Aryeh commented on the ticket to note the following:
>
> > My older contributions are available via git log --author simetrical. I
> > couldn't find a webpage that would display the results of the search
> that I
> > could link to. Note that that includes things from the SVN era that I
> only
> > committed and didn't author, so it's inflated (probably only slightly).
> But if
> > we leave that aside, according to git shortlog -sne, I have 1052 commits
> (after
> > updating .mailmap to merge the three different e-mail addresses I've
> used).
> > Surprisingly, this still makes me the #19 all-time contributor by number
> of
> > commits. I think I always tended to break up my commits more than a lot
> of
> > people, though.
>
>
> --
> Daniel Kinzler
> Principal Software Engineer, Core Platform
> Wikimedia Foundation
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l