Can/should my extensions be deleted from the Wikimedia Git repository?

classic Classic list List threaded Threaded
47 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Alex Monk
I think Gerrit admin permissions were abused to remove the review

On Fri, 8 Jun 2018, 11:57 Nischay Nahata, <[hidden email]> wrote:

> It did sound like a threat given that no policy has been framed around
> this, but I am glad to know that it was not your intent.
>
> Also, its strange that someone can just remove someone else's code review
> just like that on gerrit, add their own review and merge a patch.
>
>
> Regards,
> Nischay Nahata
>
>
> On Fri, Jun 8, 2018 at 3:46 PM Antoine Musso <[hidden email]> wrote:
>
> > On 08/06/2018 06:33, Nischay Nahata wrote:
> > >  I think that advertising the COC might still have been in "good
> faith",
> > > though it should have been done with a mail to the project owners.
> > >
> > > But what I find very objecting is the way the two developers have
> > > communicated on the gerrit thread. Both Antoine and Chad (both senior
> > devs
> > > that we used to look up to) behaved in a rather dictatorish manner
> which
> > is
> > > not even seen around profit making companies. Neither cared to explain
> > and
> > > discuss on the issue, while Yaron was trying his best to.
> >
> > Hello,
> >
> > I disagree with the dictatorship manner, or I would just have force
> > merged my own patch. I was more waiting for feedback from the repository
> > owner and engage in a conversation.
> >
> > I don't have an opinion about the CODE_OF_CONDUCT.md beside that it has
> > been added on all mediawiki repositories hosted on Gerrit and that it
> > became the de factor standard on GitHub.  I just happened to notice the
> > file was missing and for sack of consistency proposed a change to
> > restore it.
> >
> >
> > About my comment on Gerrit:
> >
> > | Well then can we just archive this repository please?
> >
> > I was reacting to Yaron comment about development happening somewhere
> else:
> > | @Ladsgroup - not all of the development of this software is done on
> > gerrit.wikimedia.org (actually, very little of it is).
> >
> > With the hasty conclusion on my side that: if the development is not on
> > Gerrit and Yaron doesn't want the COC.md file, he should be free to move
> > to a different hosting place.
> >
> > In restrospective, I got how that could sound as a threat to arbitrarily
> > delete the repository.  *Yaron I apologize*, that never has been my
> intent.
> >
> > One sure thing, I am quite happy the topic get raised to wikitech-l
> > which has a much larger audience than a single Gerrit change.  We will
> > see what the outcome happens to be.
> >
> > cheers,
> >
> > --
> > Antoine Musso
> >
> >
> >
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Isarra Yos
In reply to this post by Gergo Tisza
On 08/06/18 09:29, Gergo Tisza wrote:
> ... I'm sure you
> wouldn't act (inside or outside Wikimedia technical spaces) in ways
> inconsistent with the spirit of the code of conduct anyway, but this was a
> silly fight to pick and I hope you'll reconsider (or if you have pragmatic
> reasons for not wanting the file, you'll explain those).

The CoC does not apply to contributors outside of Wikimedia itself. A
repository that happens to be hosted by Wikimedia is not exclusive to
Wikimedia, and a file like this can cause confusion among
contributors/users elsewhere. This is a pragmatic reason for not having
it, especially when these repositories are primarily created for these
external contributors/users.

But this is backwards - the default state was not having it in the
repositories. Changing that (across the board) was what should have
required justification, not going back. And given that it doesn't even
affect whether or not the CoC applies if the file is there or not, what
even is the point of all this?

Frankly the harsh response from proponents and handling here, to the
point of bypassing normal processes and misusing rights to enforce
something that was never even decided as a community, seems completely
at odds with the spirit and intent of the CoC in the first place. If
we're trying to make contributors feel welcome, this is if anything
doing the exact opposite.

-I

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Stephan Gambke-3

> Frankly the harsh response from proponents and handling here, to the
> point of bypassing normal processes and misusing rights to enforce
> something that was never even decided as a community, seems completely
> at odds with the spirit and intent of the CoC in the first place. If
> we're trying to make contributors feel welcome, this is if anything
> doing the exact opposite.

This!

It is not the first time that individual developers have misused their +2 rights to sidestep community processes and enforce their political views. It is this kind of repeated overreach and casual disregard for the wishes and opinions of the repo owner that makes people choose GitHub over Gerrit.

It is a pity that there is even a need for a CoC, but I am more than happy to have one if it helps to make people feel more comfortable. But insinuating that not wanting that file in each and every repo would imply disagreement with the code itself is not only insulting, it has a chilling effect on the communication here. And by now, since this has happened and has been called out repeatedly in this discussion, I consider it intentional.

The whole issue is another nice demonstration of why "benevolent" dictatorship and decisions taken "for your own good" do not work.

Incidentally, what is the procedure to request removal of +2 rights for somebody on my extension repo?

Stephan


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Yaron Koren-2
In reply to this post by Yaron Koren-2
Hi,

Antoine - thank you; I see now that your statement before to archive my
repository was just because you thought it was no longer in use. I feel
better now.

Gergo Tisza <gtisza at wikimedia.org> wrote:
> * There can be all kinds of reasons why the CoC file is not appropriate
for
> some repository (which is why it wasn't added to all repositories, just
> MediaWiki and its extensions). But if we let people remove it for the sole
> reason that they don't like the code of conduct, what does it say about
out
> commitment to enforce it?

Thanks for your thoughtful response. I just want to clarify that I do
indeed have pragmatic reasons for not wanting that file, unrelated to my
opinion of the CoC. As I wrote briefly before, I just don't think the file
is making an accurate statement, given that it implies that *all*
development of the extension is governed by the CoC, which is not the case.

I suppose that one solution which hasn't been discussed yet is to change
the wording of that file so that it says something more defensible, like
"This extension is hosted on facilities governed by the Code of Conduct",
or that kind of thing - that would at least remove the pragmatic objection
that I (and some others in this thread) have raised.

It still leaves open the question of whether the file should be made
mandatory, and if so, what the mechanism should be to determine that.

-Yaron
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Tony Thomas
In reply to this post by Stephan Gambke-3
Yaron,

> - Is CODE_OF_CONDUCT.md now really mandatory?

Always looking for more inputs, but it would be great if you can provide a
proposition.

Scenario: I am new contributor looking at your repository (possibly
would've contributed to couple of repos in the past in Github). As a
maintainer of this repo, how do you want me to know that my interactions
with your product, which might be, but not limited to (1) creating an
improvement with you or the community on your extension (2) asking for
review on an improvement with you or the community on your extension is
secured under the CoC ?

Now, I see this arguments questioning why we would even need a CoC. From my
own experience and interactions with other newcomers - I can assure you
that not everyone got through the first few months on #wikimedia-dev well.
And this do vary a lot when you add diversity to the community (you know
how that works). Anyway, I dont want to defend the need for CoC - as this
is a well studied and documented one.

The next question is always 'is something' better than 'nothing'.

Also, I see that the comments on the Gerrit patch was to the point and
might have been hurtful to you  - but lets not forget that the commit
message on the revert PR[1] was just "No Thanks" and self merged. Now this
is not "what-about-ism" - but probably I think the push back would've been
way lighter if  you would've (1) explained your case clearly there in the
commit and (2) probably came up with alternatives so we could push forward
and (3) not merged it yourself.

[1] https://gerrit.wikimedia.org/r/#/c/357614/

--
Tony Thomas
https://mediawiki.org/wiki/User:01tonythomas
--

On Fri, Jun 8, 2018 at 3:26 PM, Stephan Gambke <[hidden email]>
wrote:

>
> > Frankly the harsh response from proponents and handling here, to the
> > point of bypassing normal processes and misusing rights to enforce
> > something that was never even decided as a community, seems completely
> > at odds with the spirit and intent of the CoC in the first place. If
> > we're trying to make contributors feel welcome, this is if anything
> > doing the exact opposite.
>
> This!
>
> It is not the first time that individual developers have misused their +2
> rights to sidestep community processes and enforce their political views.
> It is this kind of repeated overreach and casual disregard for the wishes
> and opinions of the repo owner that makes people choose GitHub over Gerrit.
>
> It is a pity that there is even a need for a CoC, but I am more than happy
> to have one if it helps to make people feel more comfortable. But
> insinuating that not wanting that file in each and every repo would imply
> disagreement with the code itself is not only insulting, it has a chilling
> effect on the communication here. And by now, since this has happened and
> has been called out repeatedly in this discussion, I consider it
> intentional.
>
> The whole issue is another nice demonstration of why "benevolent"
> dictatorship and decisions taken "for your own good" do not work.
>
> Incidentally, what is the procedure to request removal of +2 rights for
> somebody on my extension repo?
>
> Stephan
>
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Chris Koerner
In reply to this post by Yaron Koren-2
> I for one think that requiring a specific filesystem structure or notice in
> a git repo is quite far afield from the sorts of things that CoC is
> designed to deal with.

I agree. I do think that as a community of practice we have many
unwritten rules and numerous expectations of how we work together. We
don't explicitly define the expectation of a README.MD file in repos
either.[0] It's a best practice and cultural expectation in our spaces
to include one. The code works the same with or with out it.

Yeah, sure a coc.md isn’t “the same”, but both are expected as
something we do as a community. If we need to write that down
somewhere so there's no repeat confusion on if it's expected or not,
that seems like a good compromise. However, I'd like to think we don't
have to define everything, but ¯\_(ツ)_/¯ .

[0] I'm waiting for someone to contradict me on this risky comparison.
:) I could not find anything explicit in
https://www.mediawiki.org/wiki/Gerrit/New_repositories or
https://www.mediawiki.org/wiki/Manual:Coding_conventions

Yours,
Chris K.

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Yaron Koren-2
In reply to this post by Yaron Koren-2
Chris Koerner <nobelx at gmail.com> wrote:
> I agree. I do think that as a community of practice we have many
> unwritten rules and numerous expectations of how we work together. We
> don't explicitly define the expectation of a README.MD file in repos
> either.[0] It's a best practice and cultural expectation in our spaces
> to include one. The code works the same with or with out it.

You probably meant just "README". This is an interesting comparison. So, if
an extension lacks a README file, and that extension's maintainer refuses
to put one in, should the extension be deleted from the Wikimedia
repository?

-Yaron
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Chris Koerner
In reply to this post by Yaron Koren-2
> You probably meant just "README". This is an interesting comparison. So, if
> an extension lacks a README file, and that extension's maintainer refuses
> to put one in, should the extension be deleted from the Wikimedia
> repository?

Let's back away from the ledge of deleting stuff. I'm not arguing for that here.

What I'm trying to get across (text lacks subtly) is that the
community is asking for you to include this file. You have refused on
grounds of a lack of explicit clarity. I'm trying to say not
everything is written down, nor does it need to be. The letter and the
spirt. :) Your peers are asking for your consideration of something
that impacts folks outside of your person. We have given this a great
deal of our attention and time. Please consider the advice of folks
who consider you a peer as well. Add the file not because it's
explicitly demanded of you, but because the community is asking you to
do so. It doesn't harm your code. It provides clarity around
expectations on how we work together.

There are voices not present in this very public conversation. I have
been approached by a few that do not feel comfortable participating
here. I don't want to see anyone's contributions deleted. I also don't
want to see an exception made in this particular case because we as a
community haven't written it down somewhere.

I'll ask you plainly and directly. Yaron, will you please add the file
to your repos?

Yours,
Chris Koerner
clkoerner.com

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Brian Wolff
In reply to this post by Chris Koerner
On Friday, June 8, 2018, Chris Koerner <[hidden email]> wrote:
>> I for one think that requiring a specific filesystem structure or notice
in

>> a git repo is quite far afield from the sorts of things that CoC is
>> designed to deal with.
>
> I agree. I do think that as a community of practice we have many
> unwritten rules and numerous expectations of how we work together. We
> don't explicitly define the expectation of a README.MD file in repos
> either.[0] It's a best practice and cultural expectation in our spaces
> to include one. The code works the same with or with out it.
>
> Yeah, sure a coc.md isn’t “the same”, but both are expected as
> something we do as a community. If we need to write that down
> somewhere so there's no repeat confusion on if it's expected or not,
> that seems like a good compromise. However, I'd like to think we don't
> have to define everything, but ¯\_(ツ)_/¯ .
>
> [0] I'm waiting for someone to contradict me on this risky comparison.
> :) I could not find anything explicit in
> https://www.mediawiki.org/wiki/Gerrit/New_repositories or
> https://www.mediawiki.org/wiki/Manual:Coding_conventions
>
> Yours,
> Chris K.
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

The issue is, it seems like this is not something we "do" as a community:

* There was a previous discussion about requiring coc.md. there was a lot
of arguing and no clear "winner", but a very significant portion of the
opinions was that CoC.md was highly recommended but not required if the
extension maintainer didnt want it. Thus supporting Yaron's position.
https://phabricator.wikimedia.org/T165540#3358929
* There is a general community norm that overriding a -2 by a maintainer of
a component is an extraordinary action, even more so when the person doing
it is not a maintainer of the extension. This situation is no where near
clear cut enough to justify that without discusion
* Generally speaking, its usually considered in poorform to have an
argument about something, lose the argument (or at least not win it), wait
a year until people forget about it, and then try and do the exact same
thing.

--
brian
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Brian Wolff
In reply to this post by Chris Koerner
On Friday, June 8, 2018, Chris Koerner
> [snip]
> There are voices not present in this very public conversation. I have
> been approached by a few that do not feel comfortable participating
> here. I don't want to see anyone's contributions deleted. I also don't
> want to see an exception made in this particular case because we as a
> community haven't written it down somewhere.
>
[snip]

Fwiw, I also had a discussion last night with someone who hasnt
participated in this discussion as of yet but stated that incidents like
this make them want to host their extensions elsewhere except they are not
willing to pass up translatewiki integration-so the people not commenting
objection goes both ways

I dont think we should consider hearsay (particularly the type where we
dont even specify the source) in discussions of these types. For one,
regardless of what view you hold you can probably always find someone on
the internet who agrees with you. Second if the people dont participate we
cannot evaluate their arguments on their merits or count them. If its not
for consensus seeking (evaluate args on merit) or for counting (voting)
what's the point?

--
brian
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Alex Monk
In reply to this post by Chris Koerner
On Fri, 8 Jun 2018, 17:08 Chris Koerner, <[hidden email]> wrote:

> > You probably meant just "README". This is an interesting comparison. So,
> if
> > an extension lacks a README file, and that extension's maintainer refuses
> > to put one in, should the extension be deleted from the Wikimedia
> > repository?
>
> Let's back away from the ledge of deleting stuff. I'm not arguing for that
> here.
>
> What I'm trying to get across (text lacks subtly) is that the
> community is asking for you to include this file.


Where? So far it's been a few individuals.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

John Doe-27
> Where? So far it's been a few individuals.


Here, here. Can you please cite the clear community decision you are
referencing? Just because a few users took unilaterally actions and most
people didn't object, that isn't

consensus.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Fæ
Yep. If anything, the consensus here demonstrates the opposite.

Fae


On Fri, 8 Jun 2018, 17:42 John, <[hidden email]> wrote:

> > Where? So far it's been a few individuals.
>
>
> Here, here. Can you please cite the clear community decision you are
> referencing? Just because a few users took unilaterally actions and most
> people didn't object, that isn't
>
> consensus.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Leon Ziemba
I noticed CODE_OF_CONDUCT.md apparently wasn't forcibly added to
repositories hosted on GitHub that are within the Wikimedia organization
(some Diffusion repos too, it seems). GitHub is not WMF infrastructure,
sure, but github.com/wikimedia/wmf-built-toolforge-tool certainly qualifies
as a Wikimedia technical space, no? I'm not taking sides on this debate --
I just wanted to point out the inconsistency.

~Leon

On Fri, Jun 8, 2018 at 12:47 PM Fæ <[hidden email]> wrote:

> Yep. If anything, the consensus here demonstrates the opposite.
>
> Fae
>
>
> On Fri, 8 Jun 2018, 17:42 John, <[hidden email]> wrote:
>
> > > Where? So far it's been a few individuals.
> >
> >
> > Here, here. Can you please cite the clear community decision you are
> > referencing? Just because a few users took unilaterally actions and most
> > people didn't object, that isn't
> >
> > consensus.
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Yaron Koren-2
In reply to this post by Yaron Koren-2
Tony Thomas <01tonythomas at gmail.com> wrote:

> Scenario: I am new contributor looking at your repository (possibly
> would've contributed to couple of repos in the past in Github). As a
> maintainer of this repo, how do you want me to know that my interactions
> with your product, which might be, but not limited to (1) creating an
> improvement with you or the community on your extension (2) asking for
> review on an improvement with you or the community on your extension is
> secured under the CoC ?

This has already been addressed by me and others on this thread, but it's
worth repeating: in this scenario, your improvements to my software are
*not necessarily* covered by the Code of Conduct. If they occur on Gerrit,
Phabricator, etc. they are; if they occur by private email, over Skype,
etc. they're not. That's why I think the file in its current wording is
misleading.

> probably I think the push back would've been
> way lighter if  you would've (1) explained your case clearly there in the
> commit and (2) probably came up with alternatives so we could push forward
> and (3) not merged it yourself.

I don't believe there was any "pushback" - the current problems started
when a few developers noticed that one of my extensions didn't have that
file.

-Yaron
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Chris Koerner
In reply to this post by Yaron Koren-2
Well, thanks gents for the replies. It looks like I was wrong in
assuming we were on the same page.

I lack the emotional energy to keep up with this discussion for now. I
appreciate Yaron taking the time to be open to my questions and
conversations. I hope you can figure it all out. Have a good weekend.

Yours,
Chris Koerner
clkoerner.com

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Greg Rundlett (freephile)
I for one definitely support the "concept" of a CoC; and the enforcement of
it.

I also definitely agree with Yaron. He's not even arguing about the merits
of a CoC. He's simply stating that the file doesn't belong in every single
repo. I wholeheartedly agree with that position. He's also arguing
(subsequent to point 1) that there was never a community decision to put
the file everywhere. I think having it in every repo is clutter and
counterproductive. Regardless of whether or not people pay attention to
banners, footers, and other "messages" about policy, standards, or rules,
you still have 'em. And they're not repeated in every single repository.  I
will assume that one major reason for GitHub placing it in every repo is
for them to "CYA" when it comes to high stakes sexual harassment lawsuits.
Now they'll make the case that it was "Posted No Trespassing" everywhere. I
can imagine that WMF is doing the same. I can also (as a consultant) see
how written policies which my clients see in my code could be construed as
a possible LIABILITY or RISK on their  part. They'll either want me to
carry more indemnity insurance, or even be disinclined to do business with
me. Not because they don't abide by the code of conduct, but because
there's an explicit notice of some obligation that creates liability.

I say take the file out of every repo. WMF has clearly stated it's policy
of having a CoC. Advertise it in the UI of the technical spaces, not the
file repositories.

~ Greg



Greg Rundlett
https://eQuality-Tech.com
https://freephile.org

On Fri, Jun 8, 2018 at 1:41 PM, Chris Koerner <[hidden email]> wrote:

> Well, thanks gents for the replies. It looks like I was wrong in
> assuming we were on the same page.
>
> I lack the emotional energy to keep up with this discussion for now. I
> appreciate Yaron taking the time to be open to my questions and
> conversations. I hope you can figure it all out. Have a good weekend.
>
> Yours,
> Chris Koerner
> clkoerner.com
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Bartosz Dziewoński
In reply to this post by nischay nahata
On Fri, Jun 8, 2018 at 12:56 PM, Nischay Nahata <[hidden email]>
wrote:

> Also, its strange that someone can just remove someone else's code review
> just like that on gerrit, add their own review and merge a patch.
>

This ability is very useful in some cases - for example, imagine a
VisualEditor patch marked as "-2 Do not merge until Parsoid patch XXXX is
deployed"; after said deployment, it is normal for someone else to remove
the -2 review and approve the patch (imagine further that the original
reviewer is on vacation).

Note that only people with the right to give -2/+2 reviews can remove
others' reviews. The fact that the review was removed is recorded in a
comment, so the potential for abuse seems low.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Bartosz Dziewoński
In reply to this post by Stephan Gambke-3
On Fri, Jun 8, 2018 at 3:26 PM, Stephan Gambke <[hidden email]>
wrote:

>
> It is not the first time that individual developers have misused their +2
> rights to sidestep community processes and enforce their political views.
> It is this kind of repeated overreach and casual disregard for the wishes
> and opinions of the repo owner that makes people choose GitHub over Gerrit.
>
> ...
>
> Incidentally, what is the procedure to request removal of +2 rights for
> somebody on my extension repo?
>

If you really wanted, and your extension is not deployed to Wikimedia
wikis, I think it could be done if you requested it on Phabricator. There
are definitely repositories where the "normal" +2 reviewers (able to +2/-2
patches in mediawiki/core and extensions) do not have access (e.g.
operations/mediawiki-config). But I'm not sure how it is implemented
technically, the reviewers' righs might apply to the "mediawiki/*
namespace"? in which case it could be a problem to change it for one repo.

In this particular case though, Chad is a Gerrit administrator, so he would
be able to merge the patch anyway. I don't think this problem calls for a
technical solution.

--
Matma Rex
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Can/should my extensions be deleted from the Wikimedia Git repository?

Stas Malyshev
In reply to this post by Chris Koerner
Hi!

> I agree. I do think that as a community of practice we have many
> unwritten rules and numerous expectations of how we work together. We
> don't explicitly define the expectation of a README.MD file in repos
> either.[0] It's a best practice and cultural expectation in our spaces
> to include one. The code works the same with or with out it.

I think there's several aspects here to consider:

a) In WMF technical spaces, and more widely, in the Mediawiki/Wikimedia
universe, I think there's universally acknowledged expectation of
certain standards of behavior, which in the Wikimedia space have been
codified in the CoC. The purpose of these expectations, as I understand
them, is to build and maintain an open, welcoming, productive and
inspiring community that would support development of Mediawiki and
Wikimedia projects. And the CoC is the instrument that we chose to
codify and implement those expectations in the Wikimedia spaces, which
applies to all of them regardless of technical means chosen to publish
or document it.
I do not think there is much disagreement about that.

b) How exactly the spaces are managed within this wide framework has a
lot of complex and tricky details. Some of which may seem trivial to
some people and highly sensitive to other people. Including which files
are placed in which repositories, who is allowed to change which
repository and for which reasons and procedures, and so on. I think
having more clear expectations on that would certainly help.

But beyond that, I think when designing and enforcing the rules for
these minute details, we should not lose the sight of why it is done,
and not make the process of CoC enforcement go against the goal of
having CoC - namely, the welcoming community. If that means sometimes
being more flexible, or having a bit more patient discussion and
resisting the urge to force your point through, even if I am completely
sure I am correct, I think it is still worth it in the long run.

c) Specifically about CoC.md file, I personally think having redundant
pointers to the documentation (both technical and about societal norms)
is highly welcome, as locating proper docs is notoriously hard and
largely unsolved problem with most code. Having the docs is half of the
problem (which we also sometimes fail at ;), having it where people
would find them is the other half. So adding of the CoC file from this
point of view is a smart move.

On the other hand, maintaining a rigid "one size fits all, no
exceptions, no discussions, shut up and comply" approach to it feels a
bit counter-productive to me. Yes, I foresee the question "if it is a
good thing, why not make everybody do it?" - and I could probably easily
write a 20-page essay on this topic, but I would limit myself here to
this - people have different points of view, and I think being more
accommodating in this case is better than having a nice set of
checkboxes checked.

What it specifically means for the specific file? I admit I don't have a
better proposal than "let's have a community discussion on it". But I
think making an open and welcoming community including sometimes being
patient in figuring out how exactly to do it. Enforcing having the file
in every single repo does not seem to be a pressing concern that would
do any harm if not brought into compliance right now. So let's see if we
can reach some consensus here.

--
Stas Malyshev
[hidden email]

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
123