Code structure

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Code structure

Robert Vogel

Hi SMW developers!

 

I’ve noticed that you have two parallel structures in your code base. There are classes in the folder “src/”, which follow PSR-4 layout, and in the folder “includes/”, which seem to follow the classic MediaWiki layout. I’m just curious: Do you plan to migrate from “includes/” to “src/” completely or has this separation some special meaning and will remain?

 

Greetings,

Robert Vogel


------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Semediawiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
Reply | Threaded
Open this post in threaded view
|

Re: Code structure

James HK
Hi,

> I've noticed that you have two parallel structures in your code base. There
> are classes in the folder "src/", which follow PSR-4 layout, and in the
> folder "includes/", which seem to follow the classic MediaWiki layout. I'm
> just curious: Do you plan to migrate from "includes/" to "src/" completely
> or has this separation some special meaning and will remain?

Yes, "src/" follows PSR-4 and due to legacy reasons classes in
"includes/" have no or very rudimentary test coverage. Once a class
meets certain criteria (one of which is sufficient test coverage among
others) it will be moved to "src/" with the objective to remove
"includes/" in future.

As you can imagine, having those classes meeting specific criteria
does not happen over night and requires certain due diligence and
iteration before we can truly say goodbye to "includes/" which until
then will remain.

Cheers

On 8/11/16, Robert Vogel <[hidden email]> wrote:

> Hi SMW developers!
>
> I've noticed that you have two parallel structures in your code base. There
> are classes in the folder "src/", which follow PSR-4 layout, and in the
> folder "includes/", which seem to follow the classic MediaWiki layout. I'm
> just curious: Do you plan to migrate from "includes/" to "src/" completely
> or has this separation some special meaning and will remain?
>
> Greetings,
> Robert Vogel
>

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Semediawiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel