Collecting UI feedback for PolyGerrit - Gerrit

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.

To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.

To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.

Non dark mode:

Here's how it looks like:

Dashboard:

https://phabricator.wikimedia.org/F26296230


Change list:

https://phabricator.wikimedia.org/F26296240

Change screen:

https://phabricator.wikimedia.org/F26296242


https://phabricator.wikimedia.org/F26296257


Dark mode: https://phabricator.wikimedia.org/F26296282


And many other UI improvements across the app.

You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/

Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.




It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Stas Malyshev
Hi!

Some tweaks that I found useful to do for myself in new UI (some can be
done custom styles/scripts etc.) and that might be interesting to
implement if possible:

1. Color coding of changes on the dashboard:
- one with +1 gets green
- one with -1/-2 gets red
- one that has merge conflict gets its own distinct color
This allows to quickly see which items can be reviewed/merged, which
ones need work, which need rebase, etc.

2. On dashboard, Owner column gets too wide sometimes. Some names are
pretty long and this space would be best used by Subject - which I do
want to see in its entirety, unlike the name for which the prefix is
almost always OK.
In fact, if we could also compress "Status" column somehow it'd be even
nicer - "Merge Conflict" message is useful but takes way too much
precious space.

3. In change view, sometimes the "related changes" box consumes too much
space, you can see it on https://phabricator.wikimedia.org/F26296242 -
it takes almost half horizontal space, despite being way less important
than the patch description. It'd be nice to put a constraint on it

4. It would be nice to be able to add people to WIP tasks without moving
it to Review status. Sometimes several people may need to cooperate on
WIP patch before it is ready to go. Of course, one can add reviwer and
then move back to WIP, but it'd be nicer to avoid extra actions.

Thanks!
--
Stas Malyshev
[hidden email]

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 For point1, there is now status badges on change screens. On the dashboard text is highlighted to tell if it's merged/abandoned/wip/private.
For point 2, upstream have implemented that which will be part of 2.16.
For point 3 they changed it on smaller screens so it would take less space (i think)
For point 4 that's already possible, just click "save" and not "start review"
    On Wednesday, 3 October 2018, 22:56:41 BST, Stas Malyshev <[hidden email]> wrote:  
 
 Hi!

Some tweaks that I found useful to do for myself in new UI (some can be
done custom styles/scripts etc.) and that might be interesting to
implement if possible:

1. Color coding of changes on the dashboard:
- one with +1 gets green
- one with -1/-2 gets red
- one that has merge conflict gets its own distinct color
This allows to quickly see which items can be reviewed/merged, which
ones need work, which need rebase, etc.

2. On dashboard, Owner column gets too wide sometimes. Some names are
pretty long and this space would be best used by Subject - which I do
want to see in its entirety, unlike the name for which the prefix is
almost always OK.
In fact, if we could also compress "Status" column somehow it'd be even
nicer - "Merge Conflict" message is useful but takes way too much
precious space.

3. In change view, sometimes the "related changes" box consumes too much
space, you can see it on https://phabricator.wikimedia.org/F26296242 -
it takes almost half horizontal space, despite being way less important
than the patch description. It'd be nice to put a constraint on it

4. It would be nice to be able to add people to WIP tasks without moving
it to Review status. Sometimes several people may need to cooperate on
WIP patch before it is ready to go. Of course, one can add reviwer and
then move back to WIP, but it'd be nicer to avoid extra actions.

Thanks!
--
Stas Malyshev
[hidden email]
 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Thiemo Kreuz
In reply to this post by Wikipedia Developers mailing list
Paladox wrote:

> i am collecting feedback for Gerrit's New UI […]

You might want to check out the CSS tweaks I developed for the old
Gerrit UI. This stylesheet removes a lot of clutter, makes Gerrit
usable on smaller laptop screens, and increases critical click
regions. If the new Gerrit UI looks as clean as my tweaked version (or
when similar tweaks can be applied to the new UI), I'm happy.

https://meta.wikimedia.org/wiki/User:Thiemo_Kreuz_(WMDE)/userContent.css

Best
Thiemo

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

addshorewiki
I'm still currently using the old UI, here are some things that I have
noticed.

#1 While comparing gerrit-review.googlesource.com and our gerrit install I
have found that the
googlesource version seems easier to look at. I think some of this is down
to the greater contrast
difference and the couple of extra seperating lines that they use. The main
one that I would like to
see on our install is line between the meta data on the left and the commit
message centre screen.

#2 My workflow now requires an extra click. I don't use git-review and
instead just use the links provided
by gerrit to checkout patches. Again, this seems to be less of an issue on
googlesource which has a
"download" button on the main patch pages, ours however is hidden within
the "more" menu.
I would like to see the download button straight away and avoid this extra
click.

#3 Upstream seems to have "sizeBars" element on each changed file
indicating the additions and
removals, I like this, and miss this from our current "old ui".

#4 When Jenkins reports on a patch the FAILURE or SUCCESS text has a text
colour of either red or
green in the old UI. googlesource also has some coloured representation of
success of failure when
reported by their CI, but our new poly gerrit doesn't seem to.

Thats it from me right now.

On Wed, 3 Oct 2018 at 23:29, Thiemo Kreuz <[hidden email]> wrote:

> Paladox wrote:
>
> > i am collecting feedback for Gerrit's New UI […]
>
> You might want to check out the CSS tweaks I developed for the old
> Gerrit UI. This stylesheet removes a lot of clutter, makes Gerrit
> usable on smaller laptop screens, and increases critical click
> regions. If the new Gerrit UI looks as clean as my tweaked version (or
> when similar tweaks can be applied to the new UI), I'm happy.
>
> https://meta.wikimedia.org/wiki/User:Thiemo_Kreuz_(WMDE)/userContent.css
>
> Best
> Thiemo
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Daniel Kinzler-3
In reply to this post by Wikipedia Developers mailing list
I have been using PolyGerrit for as long as it has been available for testing,
and my general feedback is: not perfect, but about a thousand times better than
the old ui.

Collapsible sections in the dashboard would be very helpful, and GerritBot
should not post anything about changes that are marked WIP. That's about the
biggest issues I have.

Am 03.10.2018 um 23:09 schrieb Paladox via Wikitech-l:

> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
In reply to this post by addshorewiki
 
Point 1: Upstream are running the master branch of gerrit. So as soon as 2.16 is branched and released then a point release is done we will be able to upgrade to it on gerrit.wikimedia.org.
Point 2: Same as above. That feature will roll out to gerrit.wikimedia.org as soon as we upgrade.
Point 3: This will roll out when we upgrade.
Point 4: their jenkins bot is operated by luca from gerritforge. He uses emojis in the comments which we could do now with our own install.    On Thursday, 4 October 2018, 09:16:03 BST, Addshore <[hidden email]> wrote:  
 
 I'm still currently using the old UI, here are some things that I have
noticed.

#1 While comparing gerrit-review.googlesource.com and our gerrit install I
have found that the
googlesource version seems easier to look at. I think some of this is down
to the greater contrast
difference and the couple of extra seperating lines that they use. The main
one that I would like to
see on our install is line between the meta data on the left and the commit
message centre screen.

#2 My workflow now requires an extra click. I don't use git-review and
instead just use the links provided
by gerrit to checkout patches. Again, this seems to be less of an issue on
googlesource which has a
"download" button on the main patch pages, ours however is hidden within
the "more" menu.
I would like to see the download button straight away and avoid this extra
click.

#3 Upstream seems to have "sizeBars" element on each changed file
indicating the additions and
removals, I like this, and miss this from our current "old ui".

#4 When Jenkins reports on a patch the FAILURE or SUCCESS text has a text
colour of either red or
green in the old UI. googlesource also has some coloured representation of
success of failure when
reported by their CI, but our new poly gerrit doesn't seem to.

Thats it from me right now.

On Wed, 3 Oct 2018 at 23:29, Thiemo Kreuz <[hidden email]> wrote:

> Paladox wrote:
>
> > i am collecting feedback for Gerrit's New UI […]
>
> You might want to check out the CSS tweaks I developed for the old
> Gerrit UI. This stylesheet removes a lot of clutter, makes Gerrit
> usable on smaller laptop screens, and increases critical click
> regions. If the new Gerrit UI looks as clean as my tweaked version (or
> when similar tweaks can be applied to the new UI), I'm happy.
>
> https://meta.wikimedia.org/wiki/User:Thiemo_Kreuz_(WMDE)/userContent.css
>
> Best
> Thiemo
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
In reply to this post by Daniel Kinzler-3
 I filled the collapse section on dashboard suggestion at https://bugs.chromium.org/p/gerrit/issues/detail?id=9804
    On Thursday, 4 October 2018, 10:28:29 BST, Daniel Kinzler <[hidden email]> wrote:  
 
 I have been using PolyGerrit for as long as it has been available for testing,
and my general feedback is: not perfect, but about a thousand times better than
the old ui.

Collapsible sections in the dashboard would be very helpful, and GerritBot
should not post anything about changes that are marked WIP. That's about the
biggest issues I have.

Am 03.10.2018 um 23:09 schrieb Paladox via Wikitech-l:

> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
In reply to this post by Thiemo Kreuz
 In PolyGerrit on the master branch, we can now define themes for users to try. I haven't tried building a theme yet that allows users to switch between themes.
    On Wednesday, 3 October 2018, 23:29:09 BST, Thiemo Kreuz <[hidden email]> wrote:  
 
 Paladox wrote:

> i am collecting feedback for Gerrit's New UI […]

You might want to check out the CSS tweaks I developed for the old
Gerrit UI. This stylesheet removes a lot of clutter, makes Gerrit
usable on smaller laptop screens, and increases critical click
regions. If the new Gerrit UI looks as clean as my tweaked version (or
when similar tweaks can be applied to the new UI), I'm happy.

https://meta.wikimedia.org/wiki/User:Thiemo_Kreuz_(WMDE)/userContent.css

Best
Thiemo

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

C. Scott Ananian
In reply to this post by Wikipedia Developers mailing list
The new Gerrit UI seems to be missing the "ignore whitespace" option in
diffs which the old Gerrit UI had.  That's a very useful feature when
reviewing patches which include indentation changes, for example compare:
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463559/6/lib/wt2html/TokenTransformManager.js?polygerrit=1
with
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463559/6/lib/wt2html/TokenTransformManager.js?polygerrit=0
(after setting "ignore whitespace" to "all" in the gear-shaped preference
menu in the top-right).
 --scott

On Wed, Oct 3, 2018 at 5:09 PM Paladox via Wikitech-l <
[hidden email]> wrote:

> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's
> possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI
> has recently been made the default upstream. The Old UI is going away in
> the next release after 2.16. Upstream have given PolyGerrit another update
> that looks different to the one on gerrit.wikimedia.org. PolyGerrit now
> includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or
> put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer
> or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become
> 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can
> either file your reports at
> https://phabricator.wikimedia.org/project/view/330/ or reply to the email
> with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the
> scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l



--
(http://cscott.net)
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 That has also be implemented upstream. Starting from 2.16.
https://github.com/GerritCodeReview/gerrit/commit/efc81216a1bffe599477cca32cf9d82307109ca9



    On Thursday, 4 October 2018, 17:14:05 BST, C. Scott Ananian <[hidden email]> wrote:  
 
 The new Gerrit UI seems to be missing the "ignore whitespace" option in diffs which the old Gerrit UI had.  That's a very useful feature when reviewing patches which include indentation changes, for example compare:
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463559/6/lib/wt2html/TokenTransformManager.js?polygerrit=1withhttps://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463559/6/lib/wt2html/TokenTransformManager.js?polygerrit=0(after setting "ignore whitespace" to "all" in the gear-shaped preference menu in the top-right). --scott

On Wed, Oct 3, 2018 at 5:09 PM Paladox via Wikitech-l <[hidden email]> wrote:

Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.

To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.

To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.

Non dark mode:

Here's how it looks like:

Dashboard:

https://phabricator.wikimedia.org/F26296230


Change list:

https://phabricator.wikimedia.org/F26296240

Change screen:

https://phabricator.wikimedia.org/F26296242


https://phabricator.wikimedia.org/F26296257


Dark mode: https://phabricator.wikimedia.org/F26296282


And many other UI improvements across the app.

You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/

Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.




It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


--
(http://cscott.net)  
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Gergo Tisza
In reply to this post by Wikipedia Developers mailing list
Thanks for your work on Gerrit, Paladox!

The Polygerrit upgrade looks great; the thread view is especially amazing.
(If you are not familiar with it, check this patch [1] and click "Comment
Threads" near the bottom of the screen.) I mostly have behavior issues (on
gerrit.wikimedia.org; I haven't tested whether they affect 2.16):
* URLs are hard to get right due to arcane escaping rules. I have been
completely unable to make search shortcuts that work in both the old and
new UI.
* Almost impossible to find clone URLs. (T206049, but also in the old UI I
could click through from the patch to the to the repo admin screen and
that's also impossible to find now. I see it's slightly easier in 2.16 but
still annoying.)
* For me the most unintuitive part is the relation chain, especially when
it is nonlinear. A graph view would be handy there, and also making it more
explicit what is the parent and what is the child.
* Probably not a UI thing, but it's very annoying that patch uploaders
cannot edit the description of their own patch (the gerrit patchset
description, not the commit summary).

On the plus side,
* Avatars are really nice and make the whole experience more human. (They
are not enabled on the Wikimedia Gerrit yet, right?)
* At some point search autocomplete switched from prefix-autocompletion to
substring-autocompletion (e.g. for project names). That sounds like a small
thing but it really made life a lot more convenient.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/196470
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 Yep avatars are not yet enabled, but we have implemented the backend to support it.
Changes that are left to merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/439808 and https://gerrit.wikimedia.org/r/c/operations/puppet/+/456437

What do you mean by "URLs are hard to get right due to arcane escaping rules. I have been completely unable to make search shortcuts that work in both the old and new UI."? Upstream have fixed some urls that were breaking when switching to the old ui. These fixes are on the master branch.
"Probably not a UI thing, but it's very annoying that patch uploaders cannot edit the description of their own patch (the gerrit patchset description, not the commit summary)" Filled upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9809

"* For me the most unintuitive part is the relation chain, especially when it is nonlinear. A graph view would be handy there, and also making it more explicit what is the parent and what is the child." Filed upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9810








    On Thursday, 4 October 2018, 19:15:32 BST, Gergo Tisza <[hidden email]> wrote:  
 
 Thanks for your work on Gerrit, Paladox!
The Polygerrit upgrade looks great; the thread view is especially amazing. (If you are not familiar with it, check this patch [1] and click "Comment Threads" near the bottom of the screen.) I mostly have behavior issues (on gerrit.wikimedia.org; I haven't tested whether they affect 2.16):* URLs are hard to get right due to arcane escaping rules. I have been completely unable to make search shortcuts that work in both the old and new UI.* Almost impossible to find clone URLs. (T206049, but also in the old UI I could click through from the patch to the to the repo admin screen and that's also impossible to find now. I see it's slightly easier in 2.16 but still annoying.)* For me the most unintuitive part is the relation chain, especially when it is nonlinear. A graph view would be handy there, and also making it more explicit what is the parent and what is the child.* Probably not a UI thing, but it's very annoying that patch uploaders cannot edit the description of their own patch (the gerrit patchset description, not the commit summary).
On the plus side,* Avatars are really nice and make the whole experience more human. (They are not enabled on the Wikimedia Gerrit yet, right?)* At some point search autocomplete switched from prefix-autocompletion to substring-autocompletion (e.g. for project names). That sounds like a small thing but it really made life a lot more convenient.
[1] https://gerrit-review.googlesource.com/c/gerrit/+/196470 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 Upstream just posted this https://groups.google.com/forum/#!topic/repo-discuss/yON4C-hIk-o for PolyGerrit plans in 2.16 / 3.0.
So it's confirmed that the planned removal of GWTUI will be in 3.0.
    On Thursday, 4 October 2018, 19:35:46 BST, Paladox via Wikitech-l <[hidden email]> wrote:  
 
  Yep avatars are not yet enabled, but we have implemented the backend to support it.
Changes that are left to merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/439808 and https://gerrit.wikimedia.org/r/c/operations/puppet/+/456437

What do you mean by "URLs are hard to get right due to arcane escaping rules. I have been completely unable to make search shortcuts that work in both the old and new UI."? Upstream have fixed some urls that were breaking when switching to the old ui. These fixes are on the master branch.
"Probably not a UI thing, but it's very annoying that patch uploaders cannot edit the description of their own patch (the gerrit patchset description, not the commit summary)" Filled upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9809

"* For me the most unintuitive part is the relation chain, especially when it is nonlinear. A graph view would be handy there, and also making it more explicit what is the parent and what is the child." Filed upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9810








    On Thursday, 4 October 2018, 19:15:32 BST, Gergo Tisza <[hidden email]> wrote: 
 
 Thanks for your work on Gerrit, Paladox!
The Polygerrit upgrade looks great; the thread view is especially amazing. (If you are not familiar with it, check this patch [1] and click "Comment Threads" near the bottom of the screen.) I mostly have behavior issues (on gerrit.wikimedia.org; I haven't tested whether they affect 2.16):* URLs are hard to get right due to arcane escaping rules. I have been completely unable to make search shortcuts that work in both the old and new UI.* Almost impossible to find clone URLs. (T206049, but also in the old UI I could click through from the patch to the to the repo admin screen and that's also impossible to find now. I see it's slightly easier in 2.16 but still annoying.)* For me the most unintuitive part is the relation chain, especially when it is nonlinear. A graph view would be handy there, and also making it more explicit what is the parent and what is the child.* Probably not a UI thing, but it's very annoying that patch uploaders cannot edit the description of their own patch (the gerrit patchset description, not the commit summary).
On the plus side,* Avatars are really nice and make the whole experience more human. (They are not enabled on the Wikimedia Gerrit yet, right?)* At some point search autocomplete switched from prefix-autocompletion to substring-autocompletion (e.g. for project names). That sounds like a small thing but it really made life a lot more convenient.
[1] https://gerrit-review.googlesource.com/c/gerrit/+/196470 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Daniel Zahn-2
In reply to this post by Gergo Tisza
On Thu, Oct 4, 2018 at 11:15 AM, Gergo Tisza <[hidden email]> wrote:


> * Avatars are really nice and make the whole experience more human. (They
> are not enabled on the Wikimedia Gerrit yet, right?)
>

Yes, that is/was a bit more complicated than it may seem. For security
reasons we have a separate domain for user uploads.

As you might have noticed on Phabricator we use phab.wmfusercontent.org for
uploaded files.
In the same way we needed to first create gerrit.wmfusercontent.org
to make this possible, followed by Varnish config for it, then Apache and
so on.

As Paladox pointed out a bunch of things have already been merged but at
least 2 are left open. Having reviewed/merged most of the previous ones i
will
look into pushing this forward again to finalize it. Then we will have
avatars on Gerrit.

https://phabricator.wikimedia.org/T191183#4278525

https://gerrit.wikimedia.org/r/#/q/project:operations/puppet+branch:production+topic:gerrit-avatars


--
Daniel Zahn <[hidden email]>
Operations Engineer
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Gergo Tisza
In reply to this post by Wikipedia Developers mailing list
On Thu, Oct 4, 2018 at 11:35 AM Paladox <[hidden email]> wrote:

> What do you mean by "URLs are hard to get right due to arcane escaping
> rules. I have been completely unable to make search shortcuts that work in
> both the old and new UI."? Upstream have fixed some urls that were breaking
> when switching to the old ui. These fixes are on the master branch.
>

Specifically, saved search queries involving / do not work for me in
Polygerrit (even when I don't care about old UI compatibility). It's poor
user experience in the first place that you need to enter URLs and not
search queries (with + instead of space etc), but slashes seem especially
hard to get right.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Dalba
In reply to this post by Wikipedia Developers mailing list
I have issues with copying the text of changed files:

`ctrl+a` does not work as it used to anymore: While using the
side-by-side diff view, go to a changed file, click on the old/new
revision, press `ctrl+a`. In the old UI only the text of the selected
file would have been selected, but now the whole page gets selected
which is not that useful.

Also, copying multiple lines results in extra whitespace being copied
in the middle of the lines. For example goto [1], select the text of
both lines and copy... It'll be copied as `# -*- coding: utf-8
-*-\n\t\n\t\n"""Package to hold all library tests."""` (note the
`\n\t\n\t\n` which should have been just a `\n`).

[1]: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/463061/5/tests/library_tests/__init__.py#1

On Thu, Oct 4, 2018 at 12:39 AM Paladox via Wikitech-l
<[hidden email]> wrote:

>
> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 I have filed it upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9815
    On Friday, 5 October 2018, 06:54:25 BST, Dalba <[hidden email]> wrote:  
 
 I have issues with copying the text of changed files:

`ctrl+a` does not work as it used to anymore: While using the
side-by-side diff view, go to a changed file, click on the old/new
revision, press `ctrl+a`. In the old UI only the text of the selected
file would have been selected, but now the whole page gets selected
which is not that useful.

Also, copying multiple lines results in extra whitespace being copied
in the middle of the lines. For example goto [1], select the text of
both lines and copy... It'll be copied as `# -*- coding: utf-8
-*-\n\t\n\t\n"""Package to hold all library tests."""` (note the
`\n\t\n\t\n` which should have been just a `\n`).

[1]: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/463061/5/tests/library_tests/__init__.py#1

On Thu, Oct 4, 2018 at 12:39 AM Paladox via Wikitech-l
<[hidden email]> wrote:

>
> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 Upstream have just branched 2.16 with a rc release a few hours away! So a stable release should be done shortly with all the improvements to polygerrit's ui and a inline editor too!
    On Friday, 5 October 2018, 19:26:30 BST, Paladox via Wikitech-l <[hidden email]> wrote:  
 
  I have filed it upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9815
    On Friday, 5 October 2018, 06:54:25 BST, Dalba <[hidden email]> wrote: 
 
 I have issues with copying the text of changed files:

`ctrl+a` does not work as it used to anymore: While using the
side-by-side diff view, go to a changed file, click on the old/new
revision, press `ctrl+a`. In the old UI only the text of the selected
file would have been selected, but now the whole page gets selected
which is not that useful.

Also, copying multiple lines results in extra whitespace being copied
in the middle of the lines. For example goto [1], select the text of
both lines and copy... It'll be copied as `# -*- coding: utf-8
-*-\n\t\n\t\n"""Package to hold all library tests."""` (note the
`\n\t\n\t\n` which should have been just a `\n`).

[1]: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/463061/5/tests/library_tests/__init__.py#1

On Thu, Oct 4, 2018 at 12:39 AM Paladox via Wikitech-l
<[hidden email]> wrote:

>
> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Collecting UI feedback for PolyGerrit - Gerrit

Wikipedia Developers mailing list
 I must note that with the branching of 2.16, it means that GWTUI is going away. With the removal of GWTUI in https://gerrit-review.googlesource.com/c/gerrit/+/116790

    On Tuesday, 16 October 2018, 16:30:53 BST, Paladox via Wikitech-l <[hidden email]> wrote:  
 
  Upstream have just branched 2.16 with a rc release a few hours away! So a stable release should be done shortly with all the improvements to polygerrit's ui and a inline editor too!
    On Friday, 5 October 2018, 19:26:30 BST, Paladox via Wikitech-l <[hidden email]> wrote: 
 
  I have filed it upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9815
    On Friday, 5 October 2018, 06:54:25 BST, Dalba <[hidden email]> wrote: 
 
 I have issues with copying the text of changed files:

`ctrl+a` does not work as it used to anymore: While using the
side-by-side diff view, go to a changed file, click on the old/new
revision, press `ctrl+a`. In the old UI only the text of the selected
file would have been selected, but now the whole page gets selected
which is not that useful.

Also, copying multiple lines results in extra whitespace being copied
in the middle of the lines. For example goto [1], select the text of
both lines and copy... It'll be copied as `# -*- coding: utf-8
-*-\n\t\n\t\n"""Package to hold all library tests."""` (note the
`\n\t\n\t\n` which should have been just a `\n`).

[1]: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/463061/5/tests/library_tests/__init__.py#1

On Thu, Oct 4, 2018 at 12:39 AM Paladox via Wikitech-l
<[hidden email]> wrote:

>
> Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has recently been made the default upstream. The Old UI is going away in the next release after 2.16. Upstream have given PolyGerrit another update that looks different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
>
> To switch to PolyGerrit either click the "New UI" button on the footer or put ?polygerrit=1 in the url.
>
> To switch back to GWTUI either click "Switch back to old ui" on the footer or put ?polygerrit=0 in the url.
>
> Non dark mode:
>
> Here's how it looks like:
>
> Dashboard:
>
> https://phabricator.wikimedia.org/F26296230
>
>
> Change list:
>
> https://phabricator.wikimedia.org/F26296240
>
> Change screen:
>
> https://phabricator.wikimedia.org/F26296242
>
>
> https://phabricator.wikimedia.org/F26296257
>
>
> Dark mode: https://phabricator.wikimedia.org/F26296282
>
>
> And many other UI improvements across the app.
>
> You can play around the the new ui from the master branch that will become 2.16 here https://gerrit.git.wmflabs.org/r/
>
> Please give feedback so upstream can make PolyGerrit even better! You can either file your reports at https://phabricator.wikimedia.org/project/view/330/ or reply to the email with your feedback.
>
>
>
>
> It has a dedicated team on the UI with a design researcher behind the scenes redesigning polygerrit constantly based on feedback.
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l 
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
12