Dealing with composer dependencies in early MediaWiki initialization

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Dealing with composer dependencies in early MediaWiki initialization

Kunal Mehta
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

I (with Reedy's help) recently started work on librarizing MediaWiki's
IP class into a separate composer package (wikimedia/ip-utils[1]). The
main motivation was so that the Parsoid PHP port could use it[2].

However, I ran into an unexpected hitch[3], as it seems we're using
the IP class before the composer autoloader is even intialized. Here's
the basic initialization in Setup.php:

- - AutoLoader.php (MediaWiki's)
- - Defines.php
- - DefaultSettings.php
  - $wgServer = WebRequest::detectServer()
    - Calls IP::splitHostAndPort()
- - GlobalFunctions.php
- - vendor/autoload.php (composer's)

My understanding is that composer's autoloader runs late so extensions
registering themselves using it can add their stuff to the necessary
globals.

And we call WebRequest::detectServer() in DefaultSettings.php so that
in LocalSettings.php people can use the value of $wgServer for other
stuff.

I see 3 main ways to move forward:

1. Move vendor/autoload.php earlier in Setup.php, potentially breaking
extensions that still rely on composer autoloading for initialization.
2. Set $wgServer = false or something in DefaultSettings.php, and then
fill it in later in Setup.php *after* the composer autoloader has been
loaded, potentially breaking anyone relying on the value of $wgServer
in LocalSettings.php.
3. (status quo) not librarize code that runs before composer
autoloader initialization. :(

Advice/input welcome.

[1] https://packagist.org/packages/wikimedia/ip-utils
[2]
https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717
6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46
[3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/

- -- Legoktm
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0S1oQACgkQ8QX4EBsF
Jpufrg/+J9RUUxRAtgJLEkyACE6GREis0eyEIZnWmMr3s9YpFPoqtWocFrUk6Wsn
W7d9Oda/8CW0/d894gGMn8LWIj9oWq2gMPWzCVFpg8uu3r4967qxBp+ba29uMOJw
Qpw6DhXtPvVAeUCy8P38Y5vM7TGmV+J1T5jDY21zimT1dRrJsI1KD+u/Ue3nYy/y
B1ic3i7vJfhYErdhHgN98ETXfXOaDx4rgd2N7PLjVNx3IYCC8LNiR8wSLuydfdbk
PLTT1bA2qi0h2wgcEr7Qtq9YstVotq8899rgKLtGDBwQi3qGNcdOgQGEMFDVfjfO
CsiWocj6s4oc3ScVj+Eb9xtvIqhNx+oRbWE1vKd4TmtSdyzpv6xadV60tq5qNFEY
I0cBDOWU5UFNHbvbyjK4dqIDEVhJ6LiEgLVBOj81U27s8mR4Dv/yFB3eac0ROk7p
gaEeOjfhtVU558XfpEsmu1H05VJT3kXNxK8y0UQOjy11SErzsXv6vDzyzLDJM/W7
WF0I4nyjeqVsBjLBN9li+5AnU3cAKVOCfZ+/aRYyg89Du//nJRjm+4lxnuPrGlaG
ES/nVUnkDZ9Yc/xA1yacm3Ytx9hpoY1mIZgxxxveyeU1KsNXAZ2BOGA2T7kU4yUw
Uyg+byYwI+1uVOjAVd3BInGV2R2/GmeIn9FOpthBaw8wcz0Y/8c=
=tU4+
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Bryan Davis
On Tue, Jun 25, 2019 at 8:21 PM Kunal Mehta <[hidden email]> wrote:

>
> I see 3 main ways to move forward:
>
> 1. Move vendor/autoload.php earlier in Setup.php, potentially breaking
> extensions that still rely on composer autoloading for initialization.
> 2. Set $wgServer = false or something in DefaultSettings.php, and then
> fill it in later in Setup.php *after* the composer autoloader has been
> loaded, potentially breaking anyone relying on the value of $wgServer
> in LocalSettings.php.
> 3. (status quo) not librarize code that runs before composer
> autoloader initialization. :(

There may be more entanglements here than I'm seeing, but I think that
there may be an option 4: add code in WebRequest to replace the use of
IP::splitHostAndPort() and IP::combineHostAndPort().

IP::combineHostAndPort() is trivial, and I think that
splitHostAndPort() could be replaced with a semi-clever call to
parse_url() that looked something like:

  $parts = parse_url( 'fake://' . $_SERVER[$varName] );

Bryan
--
Bryan Davis              Wikimedia Foundation    <[hidden email]>
[[m:User:BDavis_(WMF)]] Manager, Technical Engagement    Boise, ID USA
irc: bd808                                        v:415.839.6885 x6855

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Máté Szabó
In reply to this post by Kunal Mehta
Hey,

Looking at Setup.php, it seems to include the relevant items in the following order:
- DefaultSettings.php
- Composer autoloader
- LocalSettings.php or config callback

Could this allow us to initialise $wgServer in Setup.php, right after the Composer autoloader is included? It seems to me this would not break custom LocalSettings files that expect it to be set, as LocalSettings would not yet be included at that point. What do you think?

Best
----
Máté Szabó
SOFTWARE ENGINEER
+36 30 947 5903

WIKIA sp. z o.o. z siedzibą w Poznaniu, ul. Abp. A. Baraniaka 6
Sąd Rejonowy Poznań – Nowe Miasto i Wilda w Poznaniu, VIII Wydział Gospodarczy Krajowego Rejestru Sądowego, KRS 0000254365
NIP: 5252358778
Kapitał zakładowy: 50.000,00 złotych


> On 26 Jun 2019, at 04:21, Kunal Mehta <[hidden email]> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi,
>
> I (with Reedy's help) recently started work on librarizing MediaWiki's
> IP class into a separate composer package (wikimedia/ip-utils[1]). The
> main motivation was so that the Parsoid PHP port could use it[2].
>
> However, I ran into an unexpected hitch[3], as it seems we're using
> the IP class before the composer autoloader is even intialized. Here's
> the basic initialization in Setup.php:
>
> - - AutoLoader.php (MediaWiki's)
> - - Defines.php
> - - DefaultSettings.php
>  - $wgServer = WebRequest::detectServer()
>    - Calls IP::splitHostAndPort()
> - - GlobalFunctions.php
> - - vendor/autoload.php (composer's)
>
> My understanding is that composer's autoloader runs late so extensions
> registering themselves using it can add their stuff to the necessary
> globals.
>
> And we call WebRequest::detectServer() in DefaultSettings.php so that
> in LocalSettings.php people can use the value of $wgServer for other
> stuff.
>
> I see 3 main ways to move forward:
>
> 1. Move vendor/autoload.php earlier in Setup.php, potentially breaking
> extensions that still rely on composer autoloading for initialization.
> 2. Set $wgServer = false or something in DefaultSettings.php, and then
> fill it in later in Setup.php *after* the composer autoloader has been
> loaded, potentially breaking anyone relying on the value of $wgServer
> in LocalSettings.php.
> 3. (status quo) not librarize code that runs before composer
> autoloader initialization. :(
>
> Advice/input welcome.
>
> [1] https://packagist.org/packages/wikimedia/ip-utils
> [2]
> https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717
> 6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46
> [3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/
>
> - -- Legoktm
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0S1oQACgkQ8QX4EBsF
> Jpufrg/+J9RUUxRAtgJLEkyACE6GREis0eyEIZnWmMr3s9YpFPoqtWocFrUk6Wsn
> W7d9Oda/8CW0/d894gGMn8LWIj9oWq2gMPWzCVFpg8uu3r4967qxBp+ba29uMOJw
> Qpw6DhXtPvVAeUCy8P38Y5vM7TGmV+J1T5jDY21zimT1dRrJsI1KD+u/Ue3nYy/y
> B1ic3i7vJfhYErdhHgN98ETXfXOaDx4rgd2N7PLjVNx3IYCC8LNiR8wSLuydfdbk
> PLTT1bA2qi0h2wgcEr7Qtq9YstVotq8899rgKLtGDBwQi3qGNcdOgQGEMFDVfjfO
> CsiWocj6s4oc3ScVj+Eb9xtvIqhNx+oRbWE1vKd4TmtSdyzpv6xadV60tq5qNFEY
> I0cBDOWU5UFNHbvbyjK4dqIDEVhJ6LiEgLVBOj81U27s8mR4Dv/yFB3eac0ROk7p
> gaEeOjfhtVU558XfpEsmu1H05VJT3kXNxK8y0UQOjy11SErzsXv6vDzyzLDJM/W7
> WF0I4nyjeqVsBjLBN9li+5AnU3cAKVOCfZ+/aRYyg89Du//nJRjm+4lxnuPrGlaG
> ES/nVUnkDZ9Yc/xA1yacm3Ytx9hpoY1mIZgxxxveyeU1KsNXAZ2BOGA2T7kU4yUw
> Uyg+byYwI+1uVOjAVd3BInGV2R2/GmeIn9FOpthBaw8wcz0Y/8c=
> =tU4+
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

David Barratt
> Move vendor/autoload.php earlier in Setup.php

I would do that.
In an ideal world, Composer's autoloader would be called first, and
MediaWiki's autoloader would be registered through Composer. :)

> potentially breaking extensions that still rely on composer autoloading
for initialization.

That is wrong anyways. That would prevent a MediaWiki user from disabling
an extension without removing the code via the Composer CLI. Breaking
something we want to discourage, I think, is a good thing.

David Barratt (he/him)
Software Engineer, Anti-Harassment Tools
Wikimedia Foundation

On Wed, Jun 26, 2019 at 5:17 AM Máté Szabó <[hidden email]> wrote:
>
> Hey,
>
> Looking at Setup.php, it seems to include the relevant items in the
following order:
> - DefaultSettings.php
> - Composer autoloader
> - LocalSettings.php or config callback
>
> Could this allow us to initialise $wgServer in Setup.php, right after the
Composer autoloader is included? It seems to me this would not break custom
LocalSettings files that expect it to be set, as LocalSettings would not
yet be included at that point. What do you think?
>
> Best
> ----
> Máté Szabó
> SOFTWARE ENGINEER
> +36 30 947 5903
>
> WIKIA sp. z o.o. z siedzibą w Poznaniu, ul. Abp. A. Baraniaka 6
> Sąd Rejonowy Poznań – Nowe Miasto i Wilda w Poznaniu, VIII Wydział
Gospodarczy Krajowego Rejestru Sądowego, KRS 0000254365

> NIP: 5252358778
> Kapitał zakładowy: 50.000,00 złotych
>
>
> > On 26 Jun 2019, at 04:21, Kunal Mehta <[hidden email]> wrote:
> >
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> > Hi,
> >
> > I (with Reedy's help) recently started work on librarizing MediaWiki's
> > IP class into a separate composer package (wikimedia/ip-utils[1]). The
> > main motivation was so that the Parsoid PHP port could use it[2].
> >
> > However, I ran into an unexpected hitch[3], as it seems we're using
> > the IP class before the composer autoloader is even intialized. Here's
> > the basic initialization in Setup.php:
> >
> > - - AutoLoader.php (MediaWiki's)
> > - - Defines.php
> > - - DefaultSettings.php
> >  - $wgServer = WebRequest::detectServer()
> >    - Calls IP::splitHostAndPort()
> > - - GlobalFunctions.php
> > - - vendor/autoload.php (composer's)
> >
> > My understanding is that composer's autoloader runs late so extensions
> > registering themselves using it can add their stuff to the necessary
> > globals.
> >
> > And we call WebRequest::detectServer() in DefaultSettings.php so that
> > in LocalSettings.php people can use the value of $wgServer for other
> > stuff.
> >
> > I see 3 main ways to move forward:
> >
> > 1. Move vendor/autoload.php earlier in Setup.php, potentially breaking
> > extensions that still rely on composer autoloading for initialization.
> > 2. Set $wgServer = false or something in DefaultSettings.php, and then
> > fill it in later in Setup.php *after* the composer autoloader has been
> > loaded, potentially breaking anyone relying on the value of $wgServer
> > in LocalSettings.php.
> > 3. (status quo) not librarize code that runs before composer
> > autoloader initialization. :(
> >
> > Advice/input welcome.
> >
> > [1] https://packagist.org/packages/wikimedia/ip-utils
> > [2]
> > https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717
> > 6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46
> > [3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/
> >
> > - -- Legoktm
> > -----BEGIN PGP SIGNATURE-----
> >
> > iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0S1oQACgkQ8QX4EBsF
> > Jpufrg/+J9RUUxRAtgJLEkyACE6GREis0eyEIZnWmMr3s9YpFPoqtWocFrUk6Wsn
> > W7d9Oda/8CW0/d894gGMn8LWIj9oWq2gMPWzCVFpg8uu3r4967qxBp+ba29uMOJw
> > Qpw6DhXtPvVAeUCy8P38Y5vM7TGmV+J1T5jDY21zimT1dRrJsI1KD+u/Ue3nYy/y
> > B1ic3i7vJfhYErdhHgN98ETXfXOaDx4rgd2N7PLjVNx3IYCC8LNiR8wSLuydfdbk
> > PLTT1bA2qi0h2wgcEr7Qtq9YstVotq8899rgKLtGDBwQi3qGNcdOgQGEMFDVfjfO
> > CsiWocj6s4oc3ScVj+Eb9xtvIqhNx+oRbWE1vKd4TmtSdyzpv6xadV60tq5qNFEY
> > I0cBDOWU5UFNHbvbyjK4dqIDEVhJ6LiEgLVBOj81U27s8mR4Dv/yFB3eac0ROk7p
> > gaEeOjfhtVU558XfpEsmu1H05VJT3kXNxK8y0UQOjy11SErzsXv6vDzyzLDJM/W7
> > WF0I4nyjeqVsBjLBN9li+5AnU3cAKVOCfZ+/aRYyg89Du//nJRjm+4lxnuPrGlaG
> > ES/nVUnkDZ9Yc/xA1yacm3Ytx9hpoY1mIZgxxxveyeU1KsNXAZ2BOGA2T7kU4yUw
> > Uyg+byYwI+1uVOjAVd3BInGV2R2/GmeIn9FOpthBaw8wcz0Y/8c=
> > =tU4+
> > -----END PGP SIGNATURE-----
> >
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Brian Wolff
In reply to this post by Kunal Mehta
Another option is just removing the $wgServer back compat value.

The installer will automatically set $wgServer in LocalSettings.php. The
default value in DefaultSettings.php is mostly for compat with really old
installs before 1.16.

Allowing autodetection is a security vulnerability - albeit mostly
difficult to exploit. The primary method is via cache poisioning and then
either redirecting or otherwise tricking users about the fake domain. See
the original ticket https://phabricator.wikimedia.org/T30798 . Another
possibility is putting unsafe values in the host header to try and get an
xss (followed by cache poisioning so its not just self xss). Im unsure off
the top of my head what validation if any is done (im pretty sure its less
strict than legal domains) so im not sure how practical that is.

Anyways 1.16 was a long time ago, put my vote as we should make a breaking
change and just throw an exception if wgServer is not set in
LocalSettings.php

--
Brian

P.s. people with access to security tasks may also find the phab comment at
https://phabricator.wikimedia.org/T157426#3192740 interesting where some of
the implications of $wgServer were discussed (note the task was primarily
about something else and is unfortunately still secret)


On Tuesday, June 25, 2019, Kunal Mehta <[hidden email]> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi,
>
> I (with Reedy's help) recently started work on librarizing MediaWiki's
> IP class into a separate composer package (wikimedia/ip-utils[1]). The
> main motivation was so that the Parsoid PHP port could use it[2].
>
> However, I ran into an unexpected hitch[3], as it seems we're using
> the IP class before the composer autoloader is even intialized. Here's
> the basic initialization in Setup.php:
>
> - - AutoLoader.php (MediaWiki's)
> - - Defines.php
> - - DefaultSettings.php
>   - $wgServer = WebRequest::detectServer()
>     - Calls IP::splitHostAndPort()
> - - GlobalFunctions.php
> - - vendor/autoload.php (composer's)
>
> My understanding is that composer's autoloader runs late so extensions
> registering themselves using it can add their stuff to the necessary
> globals.
>
> And we call WebRequest::detectServer() in DefaultSettings.php so that
> in LocalSettings.php people can use the value of $wgServer for other
> stuff.
>
> I see 3 main ways to move forward:
>
> 1. Move vendor/autoload.php earlier in Setup.php, potentially breaking
> extensions that still rely on composer autoloading for initialization.
> 2. Set $wgServer = false or something in DefaultSettings.php, and then
> fill it in later in Setup.php *after* the composer autoloader has been
> loaded, potentially breaking anyone relying on the value of $wgServer
> in LocalSettings.php.
> 3. (status quo) not librarize code that runs before composer
> autoloader initialization. :(
>
> Advice/input welcome.
>
> [1] https://packagist.org/packages/wikimedia/ip-utils
> [2]
> https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717
> 6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46
> [3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/
>
> - -- Legoktm
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0S1oQACgkQ8QX4EBsF
> Jpufrg/+J9RUUxRAtgJLEkyACE6GREis0eyEIZnWmMr3s9YpFPoqtWocFrUk6Wsn
> W7d9Oda/8CW0/d894gGMn8LWIj9oWq2gMPWzCVFpg8uu3r4967qxBp+ba29uMOJw
> Qpw6DhXtPvVAeUCy8P38Y5vM7TGmV+J1T5jDY21zimT1dRrJsI1KD+u/Ue3nYy/y
> B1ic3i7vJfhYErdhHgN98ETXfXOaDx4rgd2N7PLjVNx3IYCC8LNiR8wSLuydfdbk
> PLTT1bA2qi0h2wgcEr7Qtq9YstVotq8899rgKLtGDBwQi3qGNcdOgQGEMFDVfjfO
> CsiWocj6s4oc3ScVj+Eb9xtvIqhNx+oRbWE1vKd4TmtSdyzpv6xadV60tq5qNFEY
> I0cBDOWU5UFNHbvbyjK4dqIDEVhJ6LiEgLVBOj81U27s8mR4Dv/yFB3eac0ROk7p
> gaEeOjfhtVU558XfpEsmu1H05VJT3kXNxK8y0UQOjy11SErzsXv6vDzyzLDJM/W7
> WF0I4nyjeqVsBjLBN9li+5AnU3cAKVOCfZ+/aRYyg89Du//nJRjm+4lxnuPrGlaG
> ES/nVUnkDZ9Yc/xA1yacm3Ytx9hpoY1mIZgxxxveyeU1KsNXAZ2BOGA2T7kU4yUw
> Uyg+byYwI+1uVOjAVd3BInGV2R2/GmeIn9FOpthBaw8wcz0Y/8c=
> =tU4+
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Tim Starling-2
On 27/6/19 10:36 am, Brian Wolff wrote:

> Another option is just removing the $wgServer back compat value.
>
> The installer will automatically set $wgServer in LocalSettings.php. The
> default value in DefaultSettings.php is mostly for compat with really old
> installs before 1.16.
>
> Allowing autodetection is a security vulnerability - albeit mostly
> difficult to exploit. The primary method is via cache poisioning and then
> either redirecting or otherwise tricking users about the fake domain. See
> the original ticket https://phabricator.wikimedia.org/T30798 .

Interesting that I wrote there: "How about this: let's set $wgServer
in the installer in 1.18, and remove $wgServer autodetection from
DefaultSettings.php a bit later, say in 1.20."

It was indeed 1.18, not 1.16, in which $wgServer started being set in
LocalSettings.php. I added it to LocalSettingsGenerator.php here:

https://www.mediawiki.org/wiki/Special:Code/MediaWiki/90105

Anyway, it's past 1.20 so I guess that would be a good thing to do.

-- Tim Starling


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Kunal Mehta
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

On 6/26/19 11:25 PM, Tim Starling wrote:

> Interesting that I wrote there: "How about this: let's set
> $wgServer in the installer in 1.18, and remove $wgServer
> autodetection from DefaultSettings.php a bit later, say in 1.20."
>
> It was indeed 1.18, not 1.16, in which $wgServer started being set
> in LocalSettings.php. I added it to LocalSettingsGenerator.php
> here:
>
> https://www.mediawiki.org/wiki/Special:Code/MediaWiki/90105
>
> Anyway, it's past 1.20 so I guess that would be a good thing to
> do.

Thanks for the background Brian and Tim, and agreed, time to get rid
of autodetection.

I wrote <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524396>,
and jenkins forced me to investigate that the CLI installer has not
been setting $wgServer in LocalSettings, leaving wikis reliant upon
autodetection.

So in the patch I added an optional --server parameter to the CLI
installer, with it defaulting to <http://localhost> if none is
provided. Does that seem acceptable enough? I'm not sure what other
behavior would be sensible.

- -- Legoktm
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0xUDAACgkQ8QX4EBsF
JpssUBAAoEXeWezEDKOYD7kn4FHwLk7grEnA9VTsD+jqRczC7PiHHv9NYu+Dg7KC
a5HH6aee09rkf6WS07/Pn+i4AFtBalnvPFyDvpniTAYIyoybpgtKUG8VCySFtw0Z
GH+ZHTjNngbWksWnecG2yD2QOvXJ/Y4AwtSfi5CshRlY/V7oU822Jvlnl3d/uaM4
cPDB/RPmmfENXkjNnopPRz537OBIHS10liivbrQP7Y5Q3GAykY6mgaP/6H8gFooq
fSlwlToKZhKh17KJFy2vkmHvsEoom+E2munR5TXJYoF9HKAfVX7SQ3Wua6tbk9P6
UCBBxy+6Q5GLilaYqkokHIOc1UyLHpdvZumXtqby6nlqa98IhmXKXZF18SVSqJ/N
zSsFSzx+lzwg8bGVy7BLh84HpTQsY6xDhe5HQDwA0Lfw3w5OvKN89bjFqOzr4IyS
YzRDeeuUXnP1+4DfdQ73DWyBVxhc+JefL+j3tINx5iamQvmR4clu+doM5ReCCyP+
OM7Qs8iMKaTBKHXa7KTLWDJ/+nfBaCORCsQEQi5oP8lo7x7rs9QOTobVO6KblOoD
U4BW6MPF9OLVMCk+KfzXtnhArX2TCTei2Wq2HsmJd46hA2pTOgAnAz9WdEA12cls
2seoepWMLB7JvoRjVx948IKK3F9nnTPGEkFUtyDMFGgvQ0jcxJE=
=0SNy
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Brad Jorsch (Anomie)
On Fri, Jul 19, 2019 at 1:09 AM Kunal Mehta <[hidden email]> wrote:

> So in the patch I added an optional --server parameter to the CLI
> installer, with it defaulting to <http://localhost> if none is
> provided. Does that seem acceptable enough? I'm not sure what other
> behavior would be sensible.
>

The other options I could think of would be to make --server a required
parameter to the CLI installer, or to let the CLI installer generate a
LocalSettings.php that does not result in a usable wiki (since it will give
the error that $wgServer needs to be set in LocalSettings.php).

--
Brad Jorsch (Anomie)
Senior Software Engineer
Wikimedia Foundation
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Martin Urbanec
Dne pá 19. čvc 2019 15:48 uživatel Brad Jorsch (Anomie) <
[hidden email]> napsal:

> On Fri, Jul 19, 2019 at 1:09 AM Kunal Mehta <[hidden email]>
> wrote:
>
> > So in the patch I added an optional --server parameter to the CLI
> > installer, with it defaulting to <http://localhost> if none is
> > provided. Does that seem acceptable enough? I'm not sure what other
> > behavior would be sensible.
> >
>
> The other options I could think of would be to make --server a required
> parameter to the CLI installer, or to let the CLI installer generate a
> LocalSettings.php that does not result in a usable wiki (since it will give
> the error that $wgServer needs to be set in LocalSettings.php).
>

I vote for the first option (--server required), or simply set it to
localhost by default, anyone capable of using a CLI installer can change
this trivially IMO.

>
> --
> Brad Jorsch (Anomie)
> Senior Software Engineer
> Wikimedia Foundation
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Dealing with composer dependencies in early MediaWiki initialization

Lucas Werkmeister
Am Fr., 19. Juli 2019 um 18:18 Uhr schrieb Martin Urbanec <
[hidden email]>:

> I vote for the first option (--server required), or simply set it to
> localhost by default, anyone capable of using a CLI installer can change
> this trivially IMO.
>

Anyone who’s using the CLI installer *manually* can do that, sure, but how
many scripts would be broken by making --server required? A lot of Travis
CI scripts, at least, judging by code search…
<https://codesearch.wmflabs.org/search/?q=maintenance%2Finstall\.php&files=travis>

Defaulting to localhost seems sensible to me.

--
Lucas Werkmeister (he/er)
Full Stack Developer

Wikimedia Deutschland e. V. | Tempelhofer Ufer 23-24 | 10963 Berlin
Phone: +49 (0)30 219 158 26-0
https://wikimedia.de

Imagine a world in which every single human being can freely share in the
sum of all knowledge. Help us to achieve our vision!
https://spenden.wikimedia.de

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/029/42207.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l