Github: WMFGerrit closing pull requests

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Github: WMFGerrit closing pull requests

Tyler Cipriani
tl;dr: If your team doesn't do any development on GitHub then this email
likely doesn't affect you.

As you may or may not know there is now a read-only replica of Gerrit
available at https://gerrit-replica.wikimedia.org/ (hooray); however,
over the weekend we noticed some missing tags from that mirror (boo).

To fix the missing tags for the replica I forced replication to run for
all repos in Gerrit today as part of a configuration restart. After a
replication sync I was able to ensure that all repos on the new replica
were now up-to-date; however, it also closed all the pull requests that
were made via pushing branches to wikimedia-org GitHub repos (which is
the work flow of several apps teams and possibly others).

Apologies for the inconvenience and thanks to Dmitry Brant and Joe
Walsh for pinging me about the problem.

I've since removed GitHub as a "mirror" -- meaning Gerrit will not
delete branches there. Paladox has filed a task upstream to allow us to
specify a full replication for a particular remote (i.e., gerrit-replica
but not GitHub) instead of all remotes[0], and for added suspenders for
our belt I've made a patch set that should exclude these projects from
replicating to from Gerrit to GitHub in the future[1].

I think all of the fallout of this change is taken care of (judging from
my GitHub search):
<https://github.com/search?p=1&q=org%3Awikimedia+is%3Aunmerged+type%3Apr+updated%3A%3E%3D2019-08-05+is%3Aclosed&type=Issues>

But if your project was affected, please either reach out to me or add
your project to the GitHub exclusion list in Puppet like in my
patchset[1] and add me as a reviewer.

Thanks and sorry
-- Tyler

[0]. <https://bugs.chromium.org/p/gerrit/issues/detail?id=11280>
[1]. <https://gerrit.wikimedia.org/r/c/operations/puppet/+/528276>

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Github: WMFGerrit closing pull requests

Joe Walsh
It’s worth mentioning that branches were deleted even if they weren’t a part of an open pull request. For example, on the wikipedia-ios repo, every branch created in the last three years was deleted. If you had work on a branch on GitHub that you don’t have locally, you should verify that it’s still available.

> On Aug 5, 2019, at 5:51 PM, Tyler Cipriani <[hidden email]> wrote:
>
> tl;dr: If your team doesn't do any development on GitHub then this email likely doesn't affect you.
>
> As you may or may not know there is now a read-only replica of Gerrit available at https://gerrit-replica.wikimedia.org/ (hooray); however, over the weekend we noticed some missing tags from that mirror (boo).
>
> To fix the missing tags for the replica I forced replication to run for all repos in Gerrit today as part of a configuration restart. After a replication sync I was able to ensure that all repos on the new replica were now up-to-date; however, it also closed all the pull requests that were made via pushing branches to wikimedia-org GitHub repos (which is the work flow of several apps teams and possibly others).
>
> Apologies for the inconvenience and thanks to Dmitry Brant and Joe Walsh for pinging me about the problem.
>
> I've since removed GitHub as a "mirror" -- meaning Gerrit will not delete branches there. Paladox has filed a task upstream to allow us to specify a full replication for a particular remote (i.e., gerrit-replica but not GitHub) instead of all remotes[0], and for added suspenders for our belt I've made a patch set that should exclude these projects from replicating to from Gerrit to GitHub in the future[1].
>
> I think all of the fallout of this change is taken care of (judging from my GitHub search): <https://github.com/search?p=1&q=org%3Awikimedia+is%3Aunmerged+type%3Apr+updated%3A%3E%3D2019-08-05+is%3Aclosed&type=Issues>
>
> But if your project was affected, please either reach out to me or add your project to the GitHub exclusion list in Puppet like in my patchset[1] and add me as a reviewer.
>
> Thanks and sorry
> -- Tyler
>
> [0]. <https://bugs.chromium.org/p/gerrit/issues/detail?id=11280>
> [1]. <https://gerrit.wikimedia.org/r/c/operations/puppet/+/528276>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l