Grant merge rights on core to Martin Urbanec

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Grant merge rights on core to Martin Urbanec

Daniel Kinzler-3
This is a request for granting merge privileges on the mediawiki group
(MediaWiki core and all extensions) per the gerrit privilege policy.
You can find the relevant ticket at <https://phabricator.wikimedia.org/T261656>.

Martin Urbanec is a long term contributor, both on the wikis and to the code
base. As a Steward, he has the trust of the community. His contributions in code
include improvements to extensions like OATHAuth and CentralAuth. He is also
helping with decoupling classes in core to improve code health, and provides
configuration patches on behalf of the community.

Martin has been particularly helpful in investigating and fixing a recent
security issue (T260485). Working with him on that, I was surprised to find out
that he doesn't have +2 rights. From what I have seen, it seems empowering him
to merge patches is long overdue.

Gerrit: https://gerrit.wikimedia.org/r/q/owner:martin.urbanec%2540wikimedia.cz
Wikipiedia: https://cs.wikipedia.org/wiki/Wikipedista:Martin_Urbanec

--
Daniel Kinzler
Principal Software Engineer, Core Platform
Wikimedia Foundation

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Grant merge rights on core to Martin Urbanec

David Barratt
I am also surprised by this and strongly support this request!

Martin has been instrumental in refactoring much of the code in the
blocking system that is essential to the mission's continued success.

[image: Wikimedia-logo black.svg] *David Barratt*
Senior Software Engineer, Anti-Harassment Tools
Wikimedia Foundation <https://wikimediafoundation.org/>


On Mon, Aug 31, 2020 at 11:30 AM Daniel Kinzler <[hidden email]>
wrote:

> This is a request for granting merge privileges on the mediawiki group
> (MediaWiki core and all extensions) per the gerrit privilege policy.
> You can find the relevant ticket at <
> https://phabricator.wikimedia.org/T261656>.
>
> Martin Urbanec is a long term contributor, both on the wikis and to the
> code
> base. As a Steward, he has the trust of the community. His contributions
> in code
> include improvements to extensions like OATHAuth and CentralAuth. He is
> also
> helping with decoupling classes in core to improve code health, and
> provides
> configuration patches on behalf of the community.
>
> Martin has been particularly helpful in investigating and fixing a recent
> security issue (T260485). Working with him on that, I was surprised to
> find out
> that he doesn't have +2 rights. From what I have seen, it seems empowering
> him
> to merge patches is long overdue.
>
> Gerrit:
> https://gerrit.wikimedia.org/r/q/owner:martin.urbanec%2540wikimedia.cz
> Wikipiedia: https://cs.wikipedia.org/wiki/Wikipedista:Martin_Urbanec
>
> --
> Daniel Kinzler
> Principal Software Engineer, Core Platform
> Wikimedia Foundation
>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Grant merge rights on core to Martin Urbanec

Kosta Harlan
Martin has also done (and continues to do) amazing work as a Czech
community ambassador for the Growth team; tangential to those
responsibilities, he's contributed fixes and features to the
GrowthExperiments extension and helped with code reviews as well.

+1 from me!

Kosta
--
Kosta Harlan (he/him)
Sr Software Engineer
Wikimedia Foundation


On Mon, Aug 31, 2020 at 5:34 PM David Barratt <[hidden email]>
wrote:

> I am also surprised by this and strongly support this request!
>
> Martin has been instrumental in refactoring much of the code in the
> blocking system that is essential to the mission's continued success.
>
> [image: Wikimedia-logo black.svg] *David Barratt*
> Senior Software Engineer, Anti-Harassment Tools
> Wikimedia Foundation <https://wikimediafoundation.org/>
>
>
> On Mon, Aug 31, 2020 at 11:30 AM Daniel Kinzler <[hidden email]>
> wrote:
>
> > This is a request for granting merge privileges on the mediawiki group
> > (MediaWiki core and all extensions) per the gerrit privilege policy.
> > You can find the relevant ticket at <
> > https://phabricator.wikimedia.org/T261656>.
> >
> > Martin Urbanec is a long term contributor, both on the wikis and to the
> > code
> > base. As a Steward, he has the trust of the community. His contributions
> > in code
> > include improvements to extensions like OATHAuth and CentralAuth. He is
> > also
> > helping with decoupling classes in core to improve code health, and
> > provides
> > configuration patches on behalf of the community.
> >
> > Martin has been particularly helpful in investigating and fixing a recent
> > security issue (T260485). Working with him on that, I was surprised to
> > find out
> > that he doesn't have +2 rights. From what I have seen, it seems
> empowering
> > him
> > to merge patches is long overdue.
> >
> > Gerrit:
> > https://gerrit.wikimedia.org/r/q/owner:martin.urbanec%2540wikimedia.cz
> > Wikipiedia: https://cs.wikipedia.org/wiki/Wikipedista:Martin_Urbanec
> >
> > --
> > Daniel Kinzler
> > Principal Software Engineer, Core Platform
> > Wikimedia Foundation
> >
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Grant merge rights on core to Martin Urbanec

Zoran Dori
Hello,
thanks for suggesting Martin for +2 right. I believe that he should be in a
related group because of his great work, so I'm supporting this.

Best regards,
Zoran
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l