I'm getting email on minor edits

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

I'm getting email on minor edits

David Biesack

We've enabled email notification on our intranet wiki. In my preferences, I have "Send me an email also for minor edits of pages" disabled but our MediaWiki 1.5.6 system is still sending me email when someone makes a minor edit. The page history shows the edit is a minor edit and the email contains

  Editor's summary: (comment...)  This is a minor edit


UserMailer.php contains
    ...
    && (!$minorEdit || ($wgEnotifMinorEdits && $watchingUser->getOption('enotifminoredits') ) )

which looks correct.

I can add

   $wgEnotifMinorEdits = false; # UPO; false: "minor edits" on pages do not trigger notification mails.

to LocalSettings.php but I'd rather give users the option to set this themselves.

Anyone have a fix for this so that my preferences are honored?

I'm using the standard MW 1.5.6; I did not download/install ENotif separately.

--
David J. Biesack     SAS Institute Inc.
(919) 531-7771       SAS Campus Drive
http://www.sas.com   Cary, NC 27513

_______________________________________________
MediaWiki-l mailing list
[hidden email]
http://mail.wikipedia.org/mailman/listinfo/mediawiki-l
Reply | Threaded
Open this post in threaded view
|

Re: I'm getting email on minor edits

David Biesack

I filed a bugzilla report on the problem I reported on this mailing list on Fri Feb 3

  http://bugzilla.wikimedia.org/show_bug.cgi?id=4918

There is a fix for that available. Here is an rcsdiff -w UserMailer.php
for the suggested fix (base64 encoded so the mailinglist does not wrap/corrupt it)

UkNTIGZpbGU6IFJDUy9Vc2VyTWFpbGVyLnBocCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xCmRp
ZmYgLXcgLXIxLjEgVXNlck1haWxlci5waHAKMjA3LDIwOGMyMDcsMjEwCjwgCQkJCQlpZiAoICgg
JGVub3RpZndhdGNobGlzdHBhZ2UgJiYgJHdhdGNoaW5nVXNlci0+Z2V0T3B0aW9uKCdlbm90aWZ3
YXRjaGxpc3RwYWdlcycpICkgfHwKPCAJCQkJCQkoICRlbm90aWZ1c2VydGFsa3BhZ2UgJiYgJHdh
dGNoaW5nVXNlci0+Z2V0T3B0aW9uKCdlbm90aWZ1c2VydGFsa3BhZ2VzJykgKQotLS0KPiAJCQkJ
CSMgc2FzZGpiIDA4RmViMDYgcGF0Y2hlZCBhcyBwZXIgaHR0cDovL2J1Z3ppbGxhLndpa2ltZWRp
YS5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MTgKPiAJCQkJCSMgU2VlIGFsc28gaHR0cDovL2N2cy5i
ZXJsaW9zLmRlL2NnaS1iaW4vdmlld2N2cy5jZ2kvZW5vdGlmd2lraS9lbm90aWZ3aWtpL2luY2x1
ZGVzL1VzZXJNYWlsZXIucGhwP2Fubm90YXRlPTEuMTAKPiAJCQkJCWlmICggKCAoICRlbm90aWZ3
YXRjaGxpc3RwYWdlICYmICR3YXRjaGluZ1VzZXItPmdldE9wdGlvbignZW5vdGlmd2F0Y2hsaXN0
cGFnZXMnKSApIHx8Cj4gCQkJCQkJKCAkZW5vdGlmdXNlcnRhbGtwYWdlICYmICR3YXRjaGluZ1Vz
ZXItPmdldE9wdGlvbignZW5vdGlmdXNlcnRhbGtwYWdlcycpICkgKQo=

--
David J. Biesack     SAS Institute Inc.
(919) 531-7771       SAS Campus Drive
http://www.sas.com   Cary, NC 27513

_______________________________________________
MediaWiki-l mailing list
[hidden email]
http://mail.wikipedia.org/mailman/listinfo/mediawiki-l