[MediaWiki-l] Phabricator tags: patch-for-review and WMF-deploy-*

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[MediaWiki-l] Phabricator tags: patch-for-review and WMF-deploy-*

Huji Lee
Hi all,

I have two questions regarding Phabricator tags:

1) When a task is closed as resolved (by merging a patch), are we supposed
to leave the patch-for-review tag or remove it?

2) Today on two occasions I noticed that a patch was merged and a task was
closed, yet ReleaseTaggerBot did not add the WMF-deploy-... tag to it. I
added it by hand [1][2] but wanted to make sure if that is fine and why the
bot didn't do it.

Thanks,

Huji

[1] https://phabricator.wikimedia.org/T147136
[2] https://phabricator.wikimedia.org/T151513
_______________________________________________
MediaWiki-l mailing list
To unsubscribe, go to:
https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
Reply | Threaded
Open this post in threaded view
|

Re: Phabricator tags: patch-for-review and WMF-deploy-*

Bartosz Dziewoński
On 2016-11-24 18:24, Huji Lee wrote:
> 1) When a task is closed as resolved (by merging a patch), are we supposed
> to leave the patch-for-review tag or remove it?

I think no one really cares. I usually remove it because it makes my
pedantic side happy. ;)


> 2) Today on two occasions I noticed that a patch was merged and a task was
> closed, yet ReleaseTaggerBot did not add the WMF-deploy-... tag to it. I
> added it by hand [1][2] but wanted to make sure if that is fine and why the
> bot didn't do it.

I've noticed that it doesn't work in real-time, it processes tasks in
batches with some delay. It should do this within a couple hours. (But
if doesn't, yes, it's fine to add the tag by hand.)


--
Bartosz Dziewoński

_______________________________________________
MediaWiki-l mailing list
To unsubscribe, go to:
https://lists.wikimedia.org/mailman/listinfo/mediawiki-l