Patchsets by new Gerrit contributors waiting for code review and/or merge

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patchsets by new Gerrit contributors waiting for code review and/or merge

Andre Klapper-2
CR0: Please review and provide guidance if you are familiar with the code, and decide (CR±1 or CR±2):

* https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Material/+/471766/
** Add scrollbar:: to view more content on sidebar
** 2018-November-06
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/472184/
** Avoid hitting DB in Category getters when they have the required info
** 2018-November-23 (rebased on 2019-March-10)
** Maintainers/Stewards: MediaWiki Platform team?

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/480039/
** Added new feature: order virtual fields by the order they inserted to list on cargo store
** 2018-December-17
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleAnalyticsMetrics/+/485488/
** fix: non-ascii page title bug
** 2019-January-20
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PipeEscape/+/486043/
** Convert PipeEscape to use extension registration
** 2019-January-23
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OdbcDatabase/+/487568/
** Fix OdbcDatabase to work under 1.32 and with current ExternalData
** 2019-February-02
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Push/+/492443/
** Use addJsConfigVars instead of addInlineScript
** 2019-February-23
** Maintainers/Stewards: ??? (mw.org says Unmaintained)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SearchStats/+/492455/
** Add i18n key searchstats
** 2019-February-23
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FirstSteps/+/492460/
** Convert FirstSteps to use extension registration
** 2019-February-27
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/492436/
** Added missing disableoathforuser message
** 2019-March-03
** Maintainers/Stewards: ??? ("Unassigned")

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/495439/
** Add PHPDocs to CargoViewData functions
** 2019-March-09
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MultiMaps/+/494860/
** Extension MultiMaps: Adding support for multiple URL in Leaflet
** 2019-March-07
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/492485/
** [bugfix] Remove link to /edithistory from page's edithistory summary.
** 2019-March-17
** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)

* https://gerrit.wikimedia.org/r/#/c/operations/software/cumin/+/497312/
** allow running cumin as a regular user
** 2019-March-18
** Maintainers/Stewards: WMF SRE?

* https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/498773/
** db::views: Bring back abuse_filter_history table
** 2019-March-25
** Maintainers/Stewards: WMF SRE?

* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/497646/
** pywikibot: Add support for property creation
** 2019-March-25 (but with a "WIP" flag)
** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)


CR+1: Please help make a decision (CR±1, CR±2) on these CR+1 patches:

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WhiteSpace/+/493168/
** Convert WhiteSpace to use extension registration
** 2019-February-27
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalContributions/+/492444/
** Use plaintextParams directly instead of using rawParams()
** 2019-February-27 (but blocked on non-removed "WIP" flag)
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CloseWikis/+/492449/
** SpecialCloseWiki: Replace the usage of global variables
** 2019-March-21
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/LastUserLogin/+/492441/
** LastUserLogin: Replace the usage of global variables
** 2019-March-21
** Maintainers/Stewards: ???


Read https://www.mediawiki.org/wiki/Gerrit/Code_review#By_project how
you can get notified of new patches in your code areas of interest.

Thanks in advance for your reviews!


Of last time's 11 listed patches,
2 got -1ed by anomie and Tgr;
2 got +2ed by by Daniel Kinzler and MatmaRex;
1 got rebased and is back to CR0.


Maintainers/Stewards data taken from https://www.mediawiki.org/wiki/Developers/Maintainers
CR0 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D0+label:Code-Review%253D0
CR+1 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D1+label:Code-Review%253E%253D%252B1+-label:Code-Review%253C%253D0

--
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Patchsets by new Gerrit contributors waiting for code review and/or merge

Jaime Crespo
For the couple I am slightly familiar with (apologies if I am mistaken):

On Thu, Apr 4, 2019 at 11:11 AM Andre Klapper <[hidden email]> wrote:
> * https://gerrit.wikimedia.org/r/#/c/operations/software/cumin/+/497312/
> ** allow running cumin as a regular user
> ** 2019-March-18
> ** Maintainers/Stewards: WMF SRE?

Cumin is maintained by the software automation subteam of SRE.

> * https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/498773/
> ** db::views: Bring back abuse_filter_history table
> ** 2019-March-25
> ** Maintainers/Stewards: WMF SRE?

Wikireplica views are maintained by the WMCS team (not SRE), although
they may or may not need assistance by SREs/security, depending on the
proposed changes.

I will bring these 2 to their attention.

Thanks for the heads up, Andre

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l