Patchsets by new Gerrit contributors waiting for code review and/or merge

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Patchsets by new Gerrit contributors waiting for code review and/or merge

Andre Klapper-2
Summary of worst repos with more than one patch waiting:
5x WikiPEG. 4x Parsoid. 3x UnblockMe. 2x Cargo. 2x PageForms. 2x MW Core.


CR0: Please review and provide guidance if you are familiar with the
code, and decide (CR±1 or CR±2):


* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/480039/
** Added new feature: order virtual fields by the order they inserted to list on cargo store
** 2018-December-17
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/511394/
** Added 'bibtex' export format.
** 2019-May-24
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleAnalyticsMetrics/+/485488/
** fix: non-ascii page title bug
** 2019-January-20
** Maintainers/Stewards: Tosfos (as per Extension page)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OdbcDatabase/+/487568/
** Fix OdbcDatabase to work under 1.32 and with current ExternalData
** 2019-February-02
** Maintainers/Stewards: ??? (Extension page says "Unmaintained")

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Newsletter/+/501019/
** Hide View Source Tab in Newsletter namespace
** 2019-April-30
** Maintainers/Stewards: ??? (Unassigned)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/508045/
** Edit Project Config
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/510791/
** Adding files
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/508047/
** Adding files
** Author is also extension author; author might need to get aware of
https://www.mediawiki.org/wiki/Gerrit/Privilege_policy#Requesting_Gerrit_privileges 
or what's the policy on self-merging these days?

* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/508092/
** remove dewiki archive template from edit restrictions
** 2019-May-05
** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/508165/
** Make autolink matching more efficient
** 2019-May-06
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/508176/
** All NULL in flattenIfArray and remove superfluous return statements
** 2019-May-06
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/512628/
** cache rule generator optimization & formatting
** 2019-May-27
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/512632/
** cache rule generator clean-up
** 2019-May-27
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507821/
** Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well
** 2019-May-06
** Maintainers/Stewards: MediaWiki Platform Team

* https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/508130/
** Create new http://www.mediawiki.org/xml/sitelist-1.1/ to reference sitelist-1.1.xsd
** 2019-May-07
** Maintainers/Stewards: MediaWiki Platform Team ?

* https://gerrit.wikimedia.org/r/#/c/operations/dns/+/508979/
** Revert "Convert most DYNA into 1H CNAME records"
** 2019-May-09
** Maintainers/Stewards: SRE

* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/429533/
** ApiEditPage: Don't swap undo and undoafter parameters
** 2019-May-11
** Maintainers/Stewards: MediaWiki Platform Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/509629/
** Minimize multiple instance forms when using the Header Tabs extension
** 2019-May-13
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/512642/
** Fix autocomplete filter function for no \w chars.
** 2019-May-27
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/510070/
** WikiPEG character class optimization
** 2019-May-14
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/510311/
** doc update
** 2019-May-27
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/511820/
** Drop legacy & unused code (T224084). Avoid use of "discard" (T224085)
** 2019-May-22
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/516455/
** chore: remove dead code and update .gitignore
** 2019-June-11
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/516457/
** a-b benchmark tests
** 2019-June-11
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ParserFunctions/+/511030/
** Introduce an additional parameter to #time and #timel functions to allow the wrapping of the result into <time> HTML tag
** 2019-May-20
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VEForAll/+/513913/
** fix update all editors before save
** 2019-June-02
** Maintainers/Stewards: ???



CR+1: Please help make a decision (CR±1, CR±2) on these CR+1 patches:

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PipeEscape/+/486043/
** Convert PipeEscape to use extension registration
** 2019-April-20
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Push/+/492443/
** Use addJsConfigVars instead of addInlineScript
** 2019-April-09
** Maintainers/Stewards: ??? (mw.org says Unmaintained)



Read https://www.mediawiki.org/wiki/Gerrit/Code_review#By_project how
you can get notified of new patches in your code areas of interest.

Thanks in advance for your reviews!



Of last time's 10 listed patches,
1 moved back from +1 to 0 (unreviewed);
1 got -1ed by Daimona Eaytoy;
2 got +2ed by Framawiki and Amire80;
1 got abandoned.



Maintainers/Stewards data taken from https://www.mediawiki.org/wiki/Developers/Maintainers
CR0 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D0+label:Code-Review%253D0
CR+1 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D1+label:Code-Review%253E%253D%252B1+-label:Code-Review%253C%253D0

--
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Patchsets by new Gerrit contributors waiting for code review and/or merge

Sam Wilson
Thanks Andre, I like these emails.

Where does the 'Maintainers/Stewards' value come from? Because the two
Cargo ones should probably be allocated Yaron Koren, who's listed both
on the extension page on mediawiki.org and is the only member of the
extension-Cargo group in Gerrit.

I only ask, because I'm never sure quite what role
https://www.mediawiki.org/wiki/Developers/Maintainers
has in determining these things.

On 6/20/19 3:08 PM, Andre Klapper wrote:

> Summary of worst repos with more than one patch waiting:
> 5x WikiPEG. 4x Parsoid. 3x UnblockMe. 2x Cargo. 2x PageForms. 2x MW Core.
>
>
> CR0: Please review and provide guidance if you are familiar with the
> code, and decide (CR±1 or CR±2):
>
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/480039/
> ** Added new feature: order virtual fields by the order they inserted to list on cargo store
> ** 2018-December-17
> ** Maintainers/Stewards: ???
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/511394/
> ** Added 'bibtex' export format.
> ** 2019-May-24
> ** Maintainers/Stewards: ???
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleAnalyticsMetrics/+/485488/
> ** fix: non-ascii page title bug
> ** 2019-January-20
> ** Maintainers/Stewards: Tosfos (as per Extension page)
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OdbcDatabase/+/487568/
> ** Fix OdbcDatabase to work under 1.32 and with current ExternalData
> ** 2019-February-02
> ** Maintainers/Stewards: ??? (Extension page says "Unmaintained")
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Newsletter/+/501019/
> ** Hide View Source Tab in Newsletter namespace
> ** 2019-April-30
> ** Maintainers/Stewards: ??? (Unassigned)
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/508045/
> ** Edit Project Config
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/510791/
> ** Adding files
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/508047/
> ** Adding files
> ** Author is also extension author; author might need to get aware of
> https://www.mediawiki.org/wiki/Gerrit/Privilege_policy#Requesting_Gerrit_privileges
> or what's the policy on self-merging these days?
>
> * https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/508092/
> ** remove dewiki archive template from edit restrictions
> ** 2019-May-05
> ** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/508165/
> ** Make autolink matching more efficient
> ** 2019-May-06
> ** Maintainers/Stewards: Parsing Team
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/508176/
> ** All NULL in flattenIfArray and remove superfluous return statements
> ** 2019-May-06
> ** Maintainers/Stewards: Parsing Team
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/512628/
> ** cache rule generator optimization & formatting
> ** 2019-May-27
> ** Maintainers/Stewards: Parsing Team
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/512632/
> ** cache rule generator clean-up
> ** 2019-May-27
> ** Maintainers/Stewards: Parsing Team
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507821/
> ** Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well
> ** 2019-May-06
> ** Maintainers/Stewards: MediaWiki Platform Team
>
> * https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/508130/
> ** Create new http://www.mediawiki.org/xml/sitelist-1.1/ to reference sitelist-1.1.xsd
> ** 2019-May-07
> ** Maintainers/Stewards: MediaWiki Platform Team ?
>
> * https://gerrit.wikimedia.org/r/#/c/operations/dns/+/508979/
> ** Revert "Convert most DYNA into 1H CNAME records"
> ** 2019-May-09
> ** Maintainers/Stewards: SRE
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/429533/
> ** ApiEditPage: Don't swap undo and undoafter parameters
> ** 2019-May-11
> ** Maintainers/Stewards: MediaWiki Platform Team
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/509629/
> ** Minimize multiple instance forms when using the Header Tabs extension
> ** 2019-May-13
> ** Maintainers/Stewards: ???
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/512642/
> ** Fix autocomplete filter function for no \w chars.
> ** 2019-May-27
> ** Maintainers/Stewards: ???
>
> * https://gerrit.wikimedia.org/r/#/c/wikipeg/+/510070/
> ** WikiPEG character class optimization
> ** 2019-May-14
> ** Maintainers/Stewards: Parsing Team ?
>
> * https://gerrit.wikimedia.org/r/#/c/wikipeg/+/510311/
> ** doc update
> ** 2019-May-27
> ** Maintainers/Stewards: Parsing Team ?
>
> * https://gerrit.wikimedia.org/r/#/c/wikipeg/+/511820/
> ** Drop legacy & unused code (T224084). Avoid use of "discard" (T224085)
> ** 2019-May-22
> ** Maintainers/Stewards: Parsing Team ?
>
> * https://gerrit.wikimedia.org/r/#/c/wikipeg/+/516455/
> ** chore: remove dead code and update .gitignore
> ** 2019-June-11
> ** Maintainers/Stewards: Parsing Team ?
>
> * https://gerrit.wikimedia.org/r/#/c/wikipeg/+/516457/
> ** a-b benchmark tests
> ** 2019-June-11
> ** Maintainers/Stewards: Parsing Team ?
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ParserFunctions/+/511030/
> ** Introduce an additional parameter to #time and #timel functions to allow the wrapping of the result into <time> HTML tag
> ** 2019-May-20
> ** Maintainers/Stewards: Parsing Team
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VEForAll/+/513913/
> ** fix update all editors before save
> ** 2019-June-02
> ** Maintainers/Stewards: ???
>
>
>
> CR+1: Please help make a decision (CR±1, CR±2) on these CR+1 patches:
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PipeEscape/+/486043/
> ** Convert PipeEscape to use extension registration
> ** 2019-April-20
> ** Maintainers/Stewards: ???
>
> * https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Push/+/492443/
> ** Use addJsConfigVars instead of addInlineScript
> ** 2019-April-09
> ** Maintainers/Stewards: ??? (mw.org says Unmaintained)
>
>
>
> Read https://www.mediawiki.org/wiki/Gerrit/Code_review#By_project how
> you can get notified of new patches in your code areas of interest.
>
> Thanks in advance for your reviews!
>
>
>
> Of last time's 10 listed patches,
> 1 moved back from +1 to 0 (unreviewed);
> 1 got -1ed by Daimona Eaytoy;
> 2 got +2ed by Framawiki and Amire80;
> 1 got abandoned.
>
>
>
> Maintainers/Stewards data taken from https://www.mediawiki.org/wiki/Developers/Maintainers
> CR0 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D0+label:Code-Review%253D0
> CR+1 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D1+label:Code-Review%253E%253D%252B1+-label:Code-Review%253C%253D0
>

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Patchsets by new Gerrit contributors waiting for code review and/or merge

Andre Klapper-2
On Thu, 2019-06-20 at 15:47 +0800, Sam Wilson wrote:
> Thanks Andre, I like these emails.
>
> Where does the 'Maintainers/Stewards' value come from? Because the
> two
> Cargo ones should probably be allocated Yaron Koren, who's listed
> both
> on the extension page on mediawiki.org and is the only member of the
> extension-Cargo group in Gerrit.

Thanks for the feedback! Maybe Cargo (et al) should be added under
https://www.mediawiki.org/wiki/Developers/Maintainers#Key_extensions ?

Plus you finally made me find "People > List Groups" in the Gerrit UI.
Might come handy for future editions. :)

andre
--
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Patchsets by new Gerrit contributors waiting for code review and/or merge

Sam Wilson
On 6/20/19 4:24 PM, Andre Klapper wrote:
> Thanks for the feedback! Maybe Cargo (et al) should be added under
> https://www.mediawiki.org/wiki/Developers/Maintainers#Key_extensions ?
>

I'll leave that for Yaron to do I guess. :-)

Is that list meant to contain all extensions that are used on more than
400 wikis? Because that looks to be 230 at the moment, going on
WikiApiary numbers [1]. It seems like a hard list to keep up to date,
and it doesn't add any info that's not already available elsewhere.

I have a vague memory that there's some tool that reads
[[Developers/Maintainers]] though, and (maybe?) adds reviewers on Gerrit
based on it. Am I imagining that?

[1]
https://wikiapiary.com/w/index.php?title=Special%3AAsk&q=%5B%5BCategory%3AExtension%5D%5D%0D%0A%5B%5BHas+website+count%3A%3A%3E400%5D%5D&po=%3FHas+website+count%0D%0A%3FHas+author%0D%0A&eq=yes&p%5Bformat%5D=broadtable&sort_num=&order_num=ASC&p%5Blimit%5D=500&p%5Boffset%5D=&p%5Blink%5D=all&p%5Bsort%5D=&p%5Bheaders%5D=show&p%5Bmainlabel%5D=&p%5Bintro%5D=&p%5Boutro%5D=&p%5Bsearchlabel%5D=...+further+results&p%5Bdefault%5D=&p%5Bclass%5D=sortable+wikitable+smwtable&p%5Bsep%5D=&eq=yes

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Patchsets by new Gerrit contributors waiting for code review and/or merge

Greg Grossmeier-2
Hi,

On Fri, Jun 21, 2019 at 11:51:10AM +0800, Sam Wilson wrote:
> Is that list meant to contain all extensions that are used on more than 400
> wikis? Because that looks to be 230 at the moment, going on WikiApiary
> numbers [1]. It seems like a hard list to keep up to date, and it doesn't
> add any info that's not already available elsewhere.

It is. For WMF teams the primary section to update is the
https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_extensions_deployed_on_the_Wikimedia_Cluster
section.

> I have a vague memory that there's some tool that reads
> [[Developers/Maintainers]] though, and (maybe?) adds reviewers on Gerrit
> based on it. Am I imagining that?

You're thinking of https://www.mediawiki.org/wiki/Git/Reviewers  :)


Best,

Greg

--
| Greg Grossmeier            GPG: B2FA 27B1 F7EB D327 6B8E |
| Release Team Manager            A18D 1138 8E47 FAC8 1C7D |

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Patchsets by new Gerrit contributors waiting for code review and/or merge

Subramanya Sastry
In reply to this post by Andre Klapper-2
On 6/20/19 2:08 AM, Andre Klapper wrote:

> Summary of worst repos with more than one patch waiting:
> 5x WikiPEG. 4x Parsoid.

Given our current narrow focus on porting Parsoid from JS to PHP, this
situation will continue for maybe another 2 months since we are not
merging code on the JS side unless it is part of code cleanup /
refactoring / fixes to aid the porting.

Tim, C.Scott, and I have engaged with them on Phabricator on a few of
their many tasks [1] and have clarified on a couple of the tasks that we
aren't able to engage with this work at this time. After this wikitech-l
email, I once again mentioned this on gerrit on one of their patches and
they have acknowledged that they are aware of the hold up. [2]

Any changes we accept to the JS code base will either have to be ported
to PHP, and besides review, we would have to put that code through QA,
and deploy it all of which adds to our critical path of porting and
eventually deploying. Since we are in code freeze mode, any lengthening
of this path will have impacts on all projects and clients downstream
since we aren't fixing bugs or supporting other requests for any of them.

The good news is that we are pretty much done with the core porting and
we are beginning to enter QA and performance testing phase over the next
quarter and if all goes well, we'll have deployed Parsoid/PHP to
production by the end of that quarter. At that time, we'll revisit these
patches and see what is relevant in the PHP landscape.

Thanks for all your patience,

Subbu.

( Parsing Team )

[1] https://phabricator.wikimedia.org/p/Dan1wang/

[2]
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/508165#message-45472b2c188a560f92f3b44f454083638f15ab33


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l