Pending (false positive?) translations on Gerrit to Toolforge tools

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Pending (false positive?) translations on Gerrit to Toolforge tools

Derick Alangi
Hi,

Looking at
https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., there
are pending translations to Toolforge tools which are failing due to false
positives? AFAIK, Raimond usually cleans such up for MW extensions but I'm
not sure for tools.

So please if anyone knows the maintainers of these tools, he/she can just
add them so they can review these translations and merge them? For a while
now, they've been stacking on each other.

Thanks!
*--*
*</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Amir E. Aharoni
‫בתאריך יום א׳, 28 באפר׳ 2019 ב-12:16 מאת ‪Derick Alangi‬‏ <‪
[hidden email]‬‏>:‬

> Hi,
>
> Looking at
> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., there
> are pending translations to Toolforge tools which are failing due to false
> positives?


The link doesn't work for me.

Which tools are you talking about?
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Derick Alangi
Hi,

The link works for me. But let me get a list of the tools copied over here;

- …/tools/crosswatch
- …/tools/commons-mass-description
<https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open>
- …/tools/weapon-of-mass-description
- …/tools/map-of-monuments
<https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open>
- wikimedia/portals
- wikimedia/wikimania-scholarships
- …/tools/commons-mass-description
- …/tools/weapon-of-mass-description

Again, for benefit of doubt, here is the link @Amir:
https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., it
should work or you can just check the dashboard of l10n-bot on Gerrit.
Thanks

*--*
*</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*


On Sun, Apr 28, 2019 at 12:37 PM Amir E. Aharoni <
[hidden email]> wrote:

> ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-12:16 מאת ‪Derick Alangi‬‏ <‪
> [hidden email]‬‏>:‬
>
> > Hi,
> >
> > Looking at
> > https://gerrit.wikimedia.org/r/dashboard/l10n-bot@...,
> there
> > are pending translations to Toolforge tools which are failing due to
> false
> > positives?
>
>
> The link doesn't work for me.
>
> Which tools are you talking about?
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Amir E. Aharoni
I'm still not able to open the link
https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., but I
am able to open this for example:
https://gerrit.wikimedia.org/r/#/q/project:labs/tools/crosswatch

And it indeed looks like there are a few stuck patches from L10n-bot.

This is not supposed to happen. They are supposed to be automatically
merged.

Looks like a continuous integration (CI) bug somewhere, but I'm not sure
where exactly. Can you please report a Phabricator ticket with the
translatewiki tag, and with a list of all the tools that are failing?

--
Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
http://aharoni.wordpress.com
‪“We're living in pieces,
I want to live in peace.” – T. Moore‬


‫בתאריך יום א׳, 28 באפר׳ 2019 ב-15:03 מאת ‪Derick Alangi‬‏ <‪
[hidden email]‬‏>:‬

> Hi,
>
> The link works for me. But let me get a list of the tools copied over here;
>
> - …/tools/crosswatch
> - …/tools/commons-mass-description
> <
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open
> >
> - …/tools/weapon-of-mass-description
> - …/tools/map-of-monuments
> <
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open
> >
> - wikimedia/portals
> - wikimedia/wikimania-scholarships
> - …/tools/commons-mass-description
> - …/tools/weapon-of-mass-description
>
> Again, for benefit of doubt, here is the link @Amir:
> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., it
> should work or you can just check the dashboard of l10n-bot on Gerrit.
> Thanks
>
> *--*
> *</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*
>
>
> On Sun, Apr 28, 2019 at 12:37 PM Amir E. Aharoni <
> [hidden email]> wrote:
>
> > ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-12:16 מאת ‪Derick Alangi‬‏ <‪
> > [hidden email]‬‏>:‬
> >
> > > Hi,
> > >
> > > Looking at
> > > https://gerrit.wikimedia.org/r/dashboard/l10n-bot@...,
> > there
> > > are pending translations to Toolforge tools which are failing due to
> > false
> > > positives?
> >
> >
> > The link doesn't work for me.
> >
> > Which tools are you talking about?
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Derick Alangi
Hi Amir,

Task filed, see: T222035. Thanks!

*--*
*</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*


On Sun, Apr 28, 2019 at 1:12 PM Amir E. Aharoni <
[hidden email]> wrote:

> I'm still not able to open the link
> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., but I
> am able to open this for example:
> https://gerrit.wikimedia.org/r/#/q/project:labs/tools/crosswatch
>
> And it indeed looks like there are a few stuck patches from L10n-bot.
>
> This is not supposed to happen. They are supposed to be automatically
> merged.
>
> Looks like a continuous integration (CI) bug somewhere, but I'm not sure
> where exactly. Can you please report a Phabricator ticket with the
> translatewiki tag, and with a list of all the tools that are failing?
>
> --
> Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
> http://aharoni.wordpress.com
> ‪“We're living in pieces,
> I want to live in peace.” – T. Moore‬
>
>
> ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-15:03 מאת ‪Derick Alangi‬‏ <‪
> [hidden email]‬‏>:‬
>
> > Hi,
> >
> > The link works for me. But let me get a list of the tools copied over
> here;
> >
> > - …/tools/crosswatch
> > - …/tools/commons-mass-description
> > <
> >
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open
> > >
> > - …/tools/weapon-of-mass-description
> > - …/tools/map-of-monuments
> > <
> >
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open
> > >
> > - wikimedia/portals
> > - wikimedia/wikimania-scholarships
> > - …/tools/commons-mass-description
> > - …/tools/weapon-of-mass-description
> >
> > Again, for benefit of doubt, here is the link @Amir:
> > https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., it
> > should work or you can just check the dashboard of l10n-bot on Gerrit.
> > Thanks
> >
> > *--*
> > *</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*
> >
> >
> > On Sun, Apr 28, 2019 at 12:37 PM Amir E. Aharoni <
> > [hidden email]> wrote:
> >
> > > ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-12:16 מאת ‪Derick Alangi‬‏ <‪
> > > [hidden email]‬‏>:‬
> > >
> > > > Hi,
> > > >
> > > > Looking at
> > > > https://gerrit.wikimedia.org/r/dashboard/l10n-bot@...,
> > > there
> > > > are pending translations to Toolforge tools which are failing due to
> > > false
> > > > positives?
> > >
> > >
> > > The link doesn't work for me.
> > >
> > > Which tools are you talking about?
> > > _______________________________________________
> > > Wikitech-l mailing list
> > > [hidden email]
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Alex Monk
In reply to this post by Amir E. Aharoni
Working link to l10n-bot's dashboard:
https://gerrit.wikimedia.org/r/#/dashboard/137

On Sun, 28 Apr 2019 at 13:12, Amir E. Aharoni <[hidden email]>
wrote:

> I'm still not able to open the link
> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., but I
> am able to open this for example:
> https://gerrit.wikimedia.org/r/#/q/project:labs/tools/crosswatch
>
> And it indeed looks like there are a few stuck patches from L10n-bot.
>
> This is not supposed to happen. They are supposed to be automatically
> merged.
>
> Looks like a continuous integration (CI) bug somewhere, but I'm not sure
> where exactly. Can you please report a Phabricator ticket with the
> translatewiki tag, and with a list of all the tools that are failing?
>
> --
> Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
> http://aharoni.wordpress.com
> ‪“We're living in pieces,
> I want to live in peace.” – T. Moore‬
>
>
> ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-15:03 מאת ‪Derick Alangi‬‏ <‪
> [hidden email]‬‏>:‬
>
> > Hi,
> >
> > The link works for me. But let me get a list of the tools copied over
> here;
> >
> > - …/tools/crosswatch
> > - …/tools/commons-mass-description
> > <
> >
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open
> > >
> > - …/tools/weapon-of-mass-description
> > - …/tools/map-of-monuments
> > <
> >
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open
> > >
> > - wikimedia/portals
> > - wikimedia/wikimania-scholarships
> > - …/tools/commons-mass-description
> > - …/tools/weapon-of-mass-description
> >
> > Again, for benefit of doubt, here is the link @Amir:
> > https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., it
> > should work or you can just check the dashboard of l10n-bot on Gerrit.
> > Thanks
> >
> > *--*
> > *</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*
> >
> >
> > On Sun, Apr 28, 2019 at 12:37 PM Amir E. Aharoni <
> > [hidden email]> wrote:
> >
> > > ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-12:16 מאת ‪Derick Alangi‬‏ <‪
> > > [hidden email]‬‏>:‬
> > >
> > > > Hi,
> > > >
> > > > Looking at
> > > > https://gerrit.wikimedia.org/r/dashboard/l10n-bot@...,
> > > there
> > > > are pending translations to Toolforge tools which are failing due to
> > > false
> > > > positives?
> > >
> > >
> > > The link doesn't work for me.
> > >
> > > Which tools are you talking about?
> > > _______________________________________________
> > > Wikitech-l mailing list
> > > [hidden email]
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Sam Wilson
Are these actually false positives? Because it looks like the error is
mostly (or all?) "HTML detected. Manual review required", and so these
shouldn't be automatically merged without human review.

On 4/28/19 10:50 PM, Alex Monk wrote:

> Working link to l10n-bot's dashboard:
> https://gerrit.wikimedia.org/r/#/dashboard/137
>
> On Sun, 28 Apr 2019 at 13:12, Amir E. Aharoni <[hidden email]>
> wrote:
>
>> I'm still not able to open the link
>> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., but I
>> am able to open this for example:
>> https://gerrit.wikimedia.org/r/#/q/project:labs/tools/crosswatch
>>
>> And it indeed looks like there are a few stuck patches from L10n-bot.
>>
>> This is not supposed to happen. They are supposed to be automatically
>> merged.
>>
>> Looks like a continuous integration (CI) bug somewhere, but I'm not sure
>> where exactly. Can you please report a Phabricator ticket with the
>> translatewiki tag, and with a list of all the tools that are failing?
>>
>> --
>> Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
>> http://aharoni.wordpress.com
>> ‪“We're living in pieces,
>> I want to live in peace.” – T. Moore‬
>>
>>
>> ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-15:03 מאת ‪Derick Alangi‬‏ <‪
>> [hidden email]‬‏>:‬
>>
>>> Hi,
>>>
>>> The link works for me. But let me get a list of the tools copied over
>> here;
>>> - …/tools/crosswatch
>>> - …/tools/commons-mass-description
>>> <
>>>
>> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open
>>> - …/tools/weapon-of-mass-description
>>> - …/tools/map-of-monuments
>>> <
>>>
>> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open
>>> - wikimedia/portals
>>> - wikimedia/wikimania-scholarships
>>> - …/tools/commons-mass-description
>>> - …/tools/weapon-of-mass-description
>>>
>>> Again, for benefit of doubt, here is the link @Amir:
>>> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@..., it
>>> should work or you can just check the dashboard of l10n-bot on Gerrit.
>>> Thanks
>>>
>>> *--*
>>> *</Derick <https://www.mediawiki.org/wiki/User:X-Savitar>>*
>>>
>>>
>>> On Sun, Apr 28, 2019 at 12:37 PM Amir E. Aharoni <
>>> [hidden email]> wrote:
>>>
>>>> ‫בתאריך יום א׳, 28 באפר׳ 2019 ב-12:16 מאת ‪Derick Alangi‬‏ <‪
>>>> [hidden email]‬‏>:‬
>>>>
>>>>> Hi,
>>>>>
>>>>> Looking at
>>>>> https://gerrit.wikimedia.org/r/dashboard/l10n-bot@...,
>>>> there
>>>>> are pending translations to Toolforge tools which are failing due to
>>>> false
>>>>> positives?
>>>>
>>>> The link doesn't work for me.
>>>>
>>>> Which tools are you talking about?
>>>> _______________________________________________
>>>> Wikitech-l mailing list
>>>> [hidden email]
>>>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>> _______________________________________________
>>> Wikitech-l mailing list
>>> [hidden email]
>>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>> _______________________________________________
>> Wikitech-l mailing list
>> [hidden email]
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

James Forrester-4
On Tue, 30 Apr 2019 at 02:55, Sam Wilson <[hidden email]> wrote:

> Are these actually false positives? Because it looks like the error is
> mostly (or all?) "HTML detected. Manual review required", and so these
> shouldn't be automatically merged without human review.
>

Correct. Those patches are waiting for the project owner to manually review
and merge them. All the older ones can be abandoned by the project owners.

Specifically, there are multiple outstanding i18n patches for crosswatch (
members
<https://gerrit.wikimedia.org/r/admin/groups/c036413a343d9d7cadd6a9b51cd700dd1b8b7b73,members>
, patches
<https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcrosswatch+status:open+owner:l10n-bot%2540translatewiki.net>),
commons-mass-description (member
<https://gerrit.wikimedia.org/r/admin/groups/1524,members>, patches
<https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open+owner:l10n-bot%2540translatewiki.net>),
and map-of-monuments (members
<https://gerrit.wikimedia.org/r/admin/groups/1522,members>, patches
<https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open+owner:l10n-bot%2540translatewiki.net>
).

J.
--
*James D. Forrester* (he/him <http://pronoun.is/he> or they/themself
<http://pronoun.is/they/.../themself>)
Wikimedia Foundation <https://wikimediafoundation.org/>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

Martin Urbanec
Since I'm the one with +2 at labs/tools/commons-mass-description and
labs/tools/map-of-monuments, I've reviewed&merged the newest patch from
l10n-bot, and abandoned the rest. Thanks for notifying me this way!

PS: Manual review detected should IMO cause an email notification... My
review work is email-based, and I have little to no chance to actually
notice I should review those patches.

Martin Urbanec

On Tue, 30 Apr 2019 at 19:28, James Forrester <[hidden email]>
wrote:

> On Tue, 30 Apr 2019 at 02:55, Sam Wilson <[hidden email]> wrote:
>
> > Are these actually false positives? Because it looks like the error is
> > mostly (or all?) "HTML detected. Manual review required", and so these
> > shouldn't be automatically merged without human review.
> >
>
> Correct. Those patches are waiting for the project owner to manually review
> and merge them. All the older ones can be abandoned by the project owners.
>
> Specifically, there are multiple outstanding i18n patches for crosswatch (
> members
> <
> https://gerrit.wikimedia.org/r/admin/groups/c036413a343d9d7cadd6a9b51cd700dd1b8b7b73,members
> >
> , patches
> <
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcrosswatch+status:open+owner:l10n-bot%2540translatewiki.net
> >),
> commons-mass-description (member
> <https://gerrit.wikimedia.org/r/admin/groups/1524,members>, patches
> <
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-description+status:open+owner:l10n-bot%2540translatewiki.net
> >),
> and map-of-monuments (members
> <https://gerrit.wikimedia.org/r/admin/groups/1522,members>, patches
> <
> https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments+status:open+owner:l10n-bot%2540translatewiki.net
> >
> ).
>
> J.
> --
> *James D. Forrester* (he/him <http://pronoun.is/he> or they/themself
> <http://pronoun.is/they/.../themself>)
> Wikimedia Foundation <https://wikimediafoundation.org/>
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Pending (false positive?) translations on Gerrit to Toolforge tools

James Forrester-4
On Wed, 1 May 2019 at 05:01, Martin Urbanec <[hidden email]>
wrote:

> Since I'm the one with +2 at labs/tools/commons-mass-description and
> labs/tools/map-of-monuments, I've reviewed&merged the newest patch from
> l10n-bot, and abandoned the rest. Thanks for notifying me this way!
>

Oh, sorry Martin. :-) Didn't check the membership of the groups, was just
giving general advice so others could see how to find and fix this in
future.


> PS: Manual review detected should IMO cause an email notification... My
> review work is email-based, and I have little to no chance to actually
> notice I should review those patches.
>

Anyone can get notified about l10n-bot patches by subscribing to everything
for each repo they care about at
https://gerrit.wikimedia.org/r/settings/#Notifications (note if you use the
old gerrit interface it'll instead be at
https://gerrit.wikimedia.org/r/#/settings/projects).

The hack to hide "noise" from l10n-bot in gerrit means you won't see the
initial commit or self-C+2 as e-mails, but you'll see the comments from
jenkins-bot as it goes through the CI process. It's a good way to keep in
touch with what languages are well-translated and if there are any obvious
translation errors (like text in the wrong script replacing existing
translations).

J.
--
*James D. Forrester* (he/him <http://pronoun.is/he> or they/themself
<http://pronoun.is/they/.../themself>)
Wikimedia Foundation <https://wikimediafoundation.org/>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l