Person of interest to blame

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Person of interest to blame

יגאל חיטרון
Hello. There was a patch, or a bug, or a bug fix in the last month that I'm
trying to find. Something changed the Special:Watchlist view and broke a
couple of gadgets. I wanted to find what was the gerrit patch, or at least
some explanation, what exactly was done, but nobody knows (Thanks a lot to
Quiddity which spent many time trying to help, you are awesome).
The problem is different HTML structure of Special:Watchlist, at least when
"Group changes by page in recent changes and watchlist" in preferences is
on. I even can't describe the difference, because it's just "looks
different". I read a roadmap for the last 50 days, and can't find anything.
A couple of people I asked can't help. One of the symptoms is different css
inside the revisions groups, bold vs unbold.
Maybe somebody can help to find a gerrit to blame? Thank you,
Igal (User:IKhitron)
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Person of interest to blame

Sébastien Santoro
You can host a local copy of Mediawiki and then use git-bisect
to find the relevant commit — https://git-scm.com/docs/git-bisect

On Tue, Oct 3, 2017 at 8:37 PM, יגאל חיטרון <[hidden email]> wrote:

> Hello. There was a patch, or a bug, or a bug fix in the last month that I'm
> trying to find. Something changed the Special:Watchlist view and broke a
> couple of gadgets. I wanted to find what was the gerrit patch, or at least
> some explanation, what exactly was done, but nobody knows (Thanks a lot to
> Quiddity which spent many time trying to help, you are awesome).
> The problem is different HTML structure of Special:Watchlist, at least when
> "Group changes by page in recent changes and watchlist" in preferences is
> on. I even can't describe the difference, because it's just "looks
> different". I read a roadmap for the last 50 days, and can't find anything.
> A couple of people I asked can't help. One of the symptoms is different css
> inside the revisions groups, bold vs unbold.
> Maybe somebody can help to find a gerrit to blame? Thank you,
> Igal (User:IKhitron)
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l



--
Sébastien Santoro aka Dereckson
http://www.dereckson.be/

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Person of interest to blame

C. Scott Ananian
In reply to this post by יגאל חיטרון
git log includes/specials/SpecialWatchlist.php suggests:

T172757 / I27bdaa1401323fa3143f79a57dc5b9773e48fd1d (sep 27)
T176857 / I90c79ef9c4819a34060515b863277fd185828ed9 (sep 27)
T176348 / If6280ad6fbad65909e1d0b2a48344e24d485aca2 (sep 21)
T173533 / I4138fde22bdd8cc55c65846b91184c3ad3057244 (sep 19)
T176155 / Idc4e450c9fa03fc78a012fb5eefa60174bb1245a (sep 18)
T175965 / I14ba792f1cd435f89b2e09067b0a0e894a0a2557 (sep 14)
T168376 / I3c75f9f2f6287414bf330f116d959d078250392d (aug 23)
T174725 / I1cb402559edb242b40a77f509480560f0636264d (sep 1)
T172030 / I65c50d75b21b3e5d7b69fdecb79c032f5d1d8853 (aug 31)
-              / I1c50b67b0a4aaddb561e79fdacd9849ffe0ded8c (aug 31)
and a bunch more in late august related to "WLFilters".

As Sebastien suggests, the easiest way to identify the problem is to run a
local copy and use git-bisect to identify exactly where the problematic
change occurred.
 --scott


On Tue, Oct 3, 2017 at 2:37 PM, יגאל חיטרון <[hidden email]> wrote:

> Hello. There was a patch, or a bug, or a bug fix in the last month that I'm
> trying to find. Something changed the Special:Watchlist view and broke a
> couple of gadgets. I wanted to find what was the gerrit patch, or at least
> some explanation, what exactly was done, but nobody knows (Thanks a lot to
> Quiddity which spent many time trying to help, you are awesome).
> The problem is different HTML structure of Special:Watchlist, at least when
> "Group changes by page in recent changes and watchlist" in preferences is
> on. I even can't describe the difference, because it's just "looks
> different". I read a roadmap for the last 50 days, and can't find anything.
> A couple of people I asked can't help. One of the symptoms is different css
> inside the revisions groups, bold vs unbold.
> Maybe somebody can help to find a gerrit to blame? Thank you,
> Igal (User:IKhitron)
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l




--
(http://cscott.net)
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Person of interest to blame

Brian Wolff
Realistically its probably in the enhancedChanges list base class somewhere
and not watchlist itself.

--
bawolff

On Tuesday, October 3, 2017, C. Scott Ananian <[hidden email]>
wrote:

> git log includes/specials/SpecialWatchlist.php suggests:
>
> T172757 / I27bdaa1401323fa3143f79a57dc5b9773e48fd1d (sep 27)
> T176857 / I90c79ef9c4819a34060515b863277fd185828ed9 (sep 27)
> T176348 / If6280ad6fbad65909e1d0b2a48344e24d485aca2 (sep 21)
> T173533 / I4138fde22bdd8cc55c65846b91184c3ad3057244 (sep 19)
> T176155 / Idc4e450c9fa03fc78a012fb5eefa60174bb1245a (sep 18)
> T175965 / I14ba792f1cd435f89b2e09067b0a0e894a0a2557 (sep 14)
> T168376 / I3c75f9f2f6287414bf330f116d959d078250392d (aug 23)
> T174725 / I1cb402559edb242b40a77f509480560f0636264d (sep 1)
> T172030 / I65c50d75b21b3e5d7b69fdecb79c032f5d1d8853 (aug 31)
> -              / I1c50b67b0a4aaddb561e79fdacd9849ffe0ded8c (aug 31)
> and a bunch more in late august related to "WLFilters".
>
> As Sebastien suggests, the easiest way to identify the problem is to run a
> local copy and use git-bisect to identify exactly where the problematic
> change occurred.
>  --scott
>
>
> On Tue, Oct 3, 2017 at 2:37 PM, יגאל חיטרון <[hidden email]>
wrote:
>
>> Hello. There was a patch, or a bug, or a bug fix in the last month that
I'm
>> trying to find. Something changed the Special:Watchlist view and broke a
>> couple of gadgets. I wanted to find what was the gerrit patch, or at
least
>> some explanation, what exactly was done, but nobody knows (Thanks a lot
to
>> Quiddity which spent many time trying to help, you are awesome).
>> The problem is different HTML structure of Special:Watchlist, at least
when
>> "Group changes by page in recent changes and watchlist" in preferences is
>> on. I even can't describe the difference, because it's just "looks
>> different". I read a roadmap for the last 50 days, and can't find
anything.
>> A couple of people I asked can't help. One of the symptoms is different
css

>> inside the revisions groups, bold vs unbold.
>> Maybe somebody can help to find a gerrit to blame? Thank you,
>> Igal (User:IKhitron)
>> _______________________________________________
>> Wikitech-l mailing list
>> [hidden email]
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>
>
>
> --
> (http://cscott.net)
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Person of interest to blame

יגאל חיטרון
Thank you all.
​Unfortunately, I can't create my wiki. I have no skills or ability to do
this.
I checked the list of tasks you sent, and maybe one of them fits, and maybe
not. This one talks about the watchlist disign copyed to another engine, as
far as I understood. Maybe during this move the bug that did not bolded
unseen revidions inside the groups "fixed by itself", who knows.
Igal


2017-10-03 22:48 GMT+03:00 Brian Wolff <[hidden email]>:

> Realistically its probably in the enhancedChanges list base class somewhere
> and not watchlist itself.
>
> --
> bawolff
>
> On Tuesday, October 3, 2017, C. Scott Ananian <[hidden email]>
> wrote:
> > git log includes/specials/SpecialWatchlist.php suggests:
> >
> > T172757 / I27bdaa1401323fa3143f79a57dc5b9773e48fd1d (sep 27)
> > T176857 / I90c79ef9c4819a34060515b863277fd185828ed9 (sep 27)
> > T176348 / If6280ad6fbad65909e1d0b2a48344e24d485aca2 (sep 21)
> > T173533 / I4138fde22bdd8cc55c65846b91184c3ad3057244 (sep 19)
> > T176155 / Idc4e450c9fa03fc78a012fb5eefa60174bb1245a (sep 18)
> > T175965 / I14ba792f1cd435f89b2e09067b0a0e894a0a2557 (sep 14)
> > T168376 / I3c75f9f2f6287414bf330f116d959d078250392d (aug 23)
> > T174725 / I1cb402559edb242b40a77f509480560f0636264d (sep 1)
> > T172030 / I65c50d75b21b3e5d7b69fdecb79c032f5d1d8853 (aug 31)
> > -              / I1c50b67b0a4aaddb561e79fdacd9849ffe0ded8c (aug 31)
> > and a bunch more in late august related to "WLFilters".
> >
> > As Sebastien suggests, the easiest way to identify the problem is to run
> a
> > local copy and use git-bisect to identify exactly where the problematic
> > change occurred.
> >  --scott
> >
> >
> > On Tue, Oct 3, 2017 at 2:37 PM, יגאל חיטרון <[hidden email]>
> wrote:
> >
> >> Hello. There was a patch, or a bug, or a bug fix in the last month that
> I'm
> >> trying to find. Something changed the Special:Watchlist view and broke a
> >> couple of gadgets. I wanted to find what was the gerrit patch, or at
> least
> >> some explanation, what exactly was done, but nobody knows (Thanks a lot
> to
> >> Quiddity which spent many time trying to help, you are awesome).
> >> The problem is different HTML structure of Special:Watchlist, at least
> when
> >> "Group changes by page in recent changes and watchlist" in preferences
> is
> >> on. I even can't describe the difference, because it's just "looks
> >> different". I read a roadmap for the last 50 days, and can't find
> anything.
> >> A couple of people I asked can't help. One of the symptoms is different
> css
> >> inside the revisions groups, bold vs unbold.
> >> Maybe somebody can help to find a gerrit to blame? Thank you,
> >> Igal (User:IKhitron)
> >> _______________________________________________
> >> Wikitech-l mailing list
> >> [hidden email]
> >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
> >
> >
> >
> > --
> > (http://cscott.net)
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Person of interest to blame

Bartosz Dziewoński
(For future reference, this seems to be related to
https://phabricator.wikimedia.org/T176367 and there was an answer there.)

On Wed, Oct 4, 2017 at 1:16 PM, יגאל חיטרון <[hidden email]> wrote:

> Thank you all.
> ​Unfortunately, I can't create my wiki. I have no skills or ability to do
> this.
> I checked the list of tasks you sent, and maybe one of them fits, and maybe
> not. This one talks about the watchlist disign copyed to another engine, as
> far as I understood. Maybe during this move the bug that did not bolded
> unseen revidions inside the groups "fixed by itself", who knows.
> Igal
> ​
>
> 2017-10-03 22:48 GMT+03:00 Brian Wolff <[hidden email]>:
>
> > Realistically its probably in the enhancedChanges list base class
> somewhere
> > and not watchlist itself.
> >
> > --
> > bawolff
> >
> > On Tuesday, October 3, 2017, C. Scott Ananian <[hidden email]>
> > wrote:
> > > git log includes/specials/SpecialWatchlist.php suggests:
> > >
> > > T172757 / I27bdaa1401323fa3143f79a57dc5b9773e48fd1d (sep 27)
> > > T176857 / I90c79ef9c4819a34060515b863277fd185828ed9 (sep 27)
> > > T176348 / If6280ad6fbad65909e1d0b2a48344e24d485aca2 (sep 21)
> > > T173533 / I4138fde22bdd8cc55c65846b91184c3ad3057244 (sep 19)
> > > T176155 / Idc4e450c9fa03fc78a012fb5eefa60174bb1245a (sep 18)
> > > T175965 / I14ba792f1cd435f89b2e09067b0a0e894a0a2557 (sep 14)
> > > T168376 / I3c75f9f2f6287414bf330f116d959d078250392d (aug 23)
> > > T174725 / I1cb402559edb242b40a77f509480560f0636264d (sep 1)
> > > T172030 / I65c50d75b21b3e5d7b69fdecb79c032f5d1d8853 (aug 31)
> > > -              / I1c50b67b0a4aaddb561e79fdacd9849ffe0ded8c (aug 31)
> > > and a bunch more in late august related to "WLFilters".
> > >
> > > As Sebastien suggests, the easiest way to identify the problem is to
> run
> > a
> > > local copy and use git-bisect to identify exactly where the problematic
> > > change occurred.
> > >  --scott
> > >
> > >
> > > On Tue, Oct 3, 2017 at 2:37 PM, יגאל חיטרון <[hidden email]>
> > wrote:
> > >
> > >> Hello. There was a patch, or a bug, or a bug fix in the last month
> that
> > I'm
> > >> trying to find. Something changed the Special:Watchlist view and
> broke a
> > >> couple of gadgets. I wanted to find what was the gerrit patch, or at
> > least
> > >> some explanation, what exactly was done, but nobody knows (Thanks a
> lot
> > to
> > >> Quiddity which spent many time trying to help, you are awesome).
> > >> The problem is different HTML structure of Special:Watchlist, at least
> > when
> > >> "Group changes by page in recent changes and watchlist" in preferences
> > is
> > >> on. I even can't describe the difference, because it's just "looks
> > >> different". I read a roadmap for the last 50 days, and can't find
> > anything.
> > >> A couple of people I asked can't help. One of the symptoms is
> different
> > css
> > >> inside the revisions groups, bold vs unbold.
> > >> Maybe somebody can help to find a gerrit to blame? Thank you,
> > >> Igal (User:IKhitron)
> > >> _______________________________________________
> > >> Wikitech-l mailing list
> > >> [hidden email]
> > >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > >
> > >
> > >
> > >
> > > --
> > > (http://cscott.net)
> > > _______________________________________________
> > > Wikitech-l mailing list
> > > [hidden email]
> > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> > _______________________________________________
> > Wikitech-l mailing list
> > [hidden email]
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> >
> _______________________________________________
> Wikitech-l mailing list
> [hidden email]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>



--
Matma Rex
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l