Re: [MediaWiki-l] git review warnings

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [MediaWiki-l] git review warnings

Martin Urbanec
Sending a copy to wikitech-l, because this is a little bit more generic
than "just" MediaWiki.

Hello,

the first one means you have something in /etc/git-review/git-review.conf,
which is probably unneeded. I suggest you to delete that file. On my
system, it doesn't exist.

The second one is caused by Gerrit update. Upstream kept refs/publish/*
working, because they know git-review is using that ref. I think that as
soon as git-review developers fixes this and you will upgrade, the warning
will disappear.

Best,
Martin

Ășt 12. 6. 2018 v 0:51 odesĂ­latel Huji Lee <[hidden email]> napsal:

> Every time I submit a patch to gerrit using the git review command, I get
> two warning messages that I ignore. I just want to make sure that I can
> continue to safely ignore them (or else, how to get rid of them).
>
> The first one says:
> Using global/system git-review config files
> (/etc/git-review/git-review.conf) is deprecated
>
> The second one says:
> remote: Pushing to refs/publish/* is deprecated, use refs/for/*
> instead.
>
> Thanks,
> Huji
> _______________________________________________
> MediaWiki-l mailing list
> To unsubscribe, go to:
> https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
>
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: [MediaWiki-l] git review warnings

Chad
On Tue, Jun 12, 2018 at 5:03 AM Martin Urbanec <[hidden email]>
wrote:

> The second one is caused by Gerrit update. Upstream kept refs/publish/*
> working, because they know git-review is using that ref. I think that as
> soon as git-review developers fixes this and you will upgrade, the warning
> will disappear.
>
>
Yeah, I guess refs/publish/* is being deprecated.

Which is pretty funny, considering refs/for/* was going to be deprecated in
favor of the newer refs/publish/*. Later, that was deemed to be a bad idea
and so the new one was deprecated and the original retained.

Any scripts that use refs/publish/* should be updated. I assume git-review
will do this in short order.

-Chad
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l