Request for checking two patches on Gerrit

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Request for checking two patches on Gerrit

Zoran Dori
Hello,
can you check last two patches from this URL:
https://gerrit.wikimedia.org/r/q/status:open+owner:zorandori4444%2540gmail.com+extension+registration
?

As tests pass now, I believe that they are good to get +2 now.

Best regards,
Zoran Dori
volunteer, Wikimedia Serbia
s: kizule.xyz e: [hidden email]

*Imagine a world in which every single human being can freely share inthe
sum of all knowledge.*
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Request for checking two patches on Gerrit

Andre Klapper-2
Heja,

On Sun, 2020-08-02 at 01:05 +0200, Zoran Dori wrote:
> can you check last two patches from this URL:
> https://gerrit.wikimedia.org/r/q/status:open+owner:zorandori4444%2540gmail.com+extension+registration

That URL lists 17 patches and sorting might be different (what's
"last"?). Please be specific already in emails which repository it's
about. Most people won't spend time to click random links only to find
out that they have no idea about some codebase.

Thanks!,
andre
--
Andre Klapper (he/him) | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/


_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Request for checking two patches on Gerrit

Zoran Dori
Hello again,
I mean on
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaFunctions/+/588778
and
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NaturalLanguageList/+/589902
.

I personally think that these patches can (should) get +2, because the
objections have been resolved and I want to organize my workflow, so I've
asked here to someone +2 them, as I believe that here is someone who can do
it.

As my laptop should be finally fixed in the next week (or in week after
it), when I get him back, I want to work on tasks which I've claimed in the
past, and for me would be great that some patches which I've already made,
be merged and tasks closed as resolved, so I can handle them easier.

Best regards,
Zoran Dori
volunteer, Wikimedia Serbia
s: kizule.tk e: [hidden email]

*Imagine a world in which every single human being can freely share inthe
sum of all knowledge.*
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Request for checking two patches on Gerrit

Daniel Zahn-2
With all due respect but i believe it does not scale to use this
mailing list to ping for individual code reviews.  Yes, we really need
to fix the issue that getting reviews is too hard and too many users
seem to filter Gerrit mail but moving that to "everyone gets mail
about all changes" does not appear to be the solution to me.

_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Request for checking two patches on Gerrit

Gergo Tisza
On Mon, Aug 3, 2020 at 7:40 PM Daniel Zahn <[hidden email]> wrote:

> With all due respect but i believe it does not scale to use this
> mailing list to ping for individual code reviews.  Yes, we really need
> to fix the issue that getting reviews is too hard and too many users
> seem to filter Gerrit mail but moving that to "everyone gets mail
> about all changes" does not appear to be the solution to me.
>

https://phabricator.wikimedia.org/T200987 has some related discussion.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Reply | Threaded
Open this post in threaded view
|

Re: Request for checking two patches on Gerrit

Zoran Dori
Hello everyone,

> With all due respect but i believe it does not scale to use this
> mailing list to ping for individual code reviews.
>
Some peoples have done this in the past, and I wanted to do this also,
because of reasons which I've already provided.

Yes, we really need to fix the issue that getting reviews is too hard and
> too many users seem to filter Gerrit mail but moving that to "everyone
> gets mail about all changes" does not appear to be the solution to me.

Right.

https://phabricator.wikimedia.org/T200987 has some related discussion.
>
 Thanks for providing this.

Best regards,

Zoran Dori
Volunteer on Wikimedia Foundation's projects
E: [hidden email]
*W:* kizule.tk
*Instagram*: https://instagram.com/iamkizule

[image: Banner] <https://www.who.int/health-topics/coronavirus>
If the email was sent outside of your working hours, feel free to reply
when you can.
_______________________________________________
Wikitech-l mailing list
[hidden email]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l