[SMW] Change I0414050e (deleteSemanticData)

[James HK]

Hi,

I haven't looked at the change[1] in full but I know
deleteSemanticData included a wfRunHooks( 'smwDeleteSemanticData',
array( $subject ) ) and with this method gone neither SMW_SQLStore2
nor SMW_SQLStore2_Writers includes the hook.

We need some of those hooks during the query cache invalidation
process. If you plan to change some of those hooks on instances where
update/delete or change events are happening, please let us know in
advance and ensure a deprecated message for other developers.

// SWM Query Cache
$wgHooks['SMWStore::updateDataBefore'][]   =
'SMWQueryCache::onUpdateDataBefore'; // invalidate on update
$wgHooks['smwDeleteSemanticData'][]        =
'SMWQueryCache::onDeleteSemanticData'; // invalidate on delete
$wgHooks['smwChangeTitle'][]               =
'SMWQueryCache::onChangeTitle'; // invalidate on moveTitle it is not
included in update

[1] https://gerrit.wikimedia.org/r/#/c/10706/

Thanks,

mwjames

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Semediawiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel

[nischay nahata]

Hi,

On Tue, Jun 19, 2012 at 6:22 AM, James HK <[hidden email]> wrote:

I haven't looked at the change[1] in full but I know
deleteSemanticData included a wfRunHooks( 'smwDeleteSemanticData',
array( $subject ) ) and with this method gone neither SMW_SQLStore2
nor SMW_SQLStore2_Writers includes the hook.

The method isn't gone, its still there in SQLStore2. However, doDatauUdate doesn't use this anymore. It instead uses deleteTableSemanticData() - which is a similar method but only deletes SMWdata from a particular table.

We need some of those hooks during the query cache invalidation
process. If you plan to change some of those hooks on instances where
update/delete or change events are happening, please let us know in
advance and ensure a deprecated message for other developers.

// SWM Query Cache
$wgHooks['SMWStore::updateDataBefore'][]   =
'SMWQueryCache::onUpdateDataBefore'; // invalidate on update
$wgHooks['smwDeleteSemanticData'][]        =
'SMWQueryCache::onDeleteSemanticData'; // invalidate on delete
$wgHooks['smwChangeTitle'][]               =
'SMWQueryCache::onChangeTitle'; // invalidate on moveTitle it is not
included in update

[1] https://gerrit.wikimedia.org/r/#/c/10706/

Thanks,

mwjames

 You surely can add new hooks in deleteTableSemanticData as per your need :)

--
Cheers,

Nischay Nahata
http://nischayn22.in

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Semediawiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel